Remove redundant OSMemoryBarrier from CFBundle.c - #5382
Open
AZero13 wants to merge 1 commit into
Open
Conversation
When a bundle is unique, it is allocated and initialized on the current thread and returned to the same thread. Since the pointer isn't published to any other thread, no memory barrier is needed to ensure initialization visibility. If the bundle is not unique, the code immediately acquires CFBundleGlobalDataLock. If a user passes the bundle pointer to another thread in a way that leads to races, that is a bug with the user, and their problem.
Contributor
|
Hm, I need to think back to why we introduced this in the first place. The comment suggests it was not safe to use with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a bundle is unique, it is allocated and initialized on the current thread and returned to the same thread.
Since the pointer isn't published to any other thread, no memory barrier is needed to ensure initialization visibility.
If the bundle is not unique, the code immediately acquires CFBundleGlobalDataLock.
If a user passes the bundle pointer to another thread in a way that leads to races, that is a bug with the user, and their problem.