Skip to content

Remove redundant OSMemoryBarrier from CFBundle.c #5382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AZero13 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove redundant OSMemoryBarrier from CFBundle.c #5382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions Sources/CoreFoundation/CFBundle.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,12 +861,6 @@ static CFBundleRef _CFBundleCreate(CFAllocatorRef allocator, CFURLRef bundleURL,
CFDictionaryRef infoDict = CFBundleGetInfoDictionary(bundle);
CFStringRef bundleID = CFBundleGetIdentifier(bundle);

// Do this so that we can use the dispatch_once on the ivar of this bundle safely
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated"
OSMemoryBarrier();
#pragma GCC diagnostic pop

// We cannot add to tables for unique bundles. Return unique bundle results here without heading into the section below where we take a lock.
if (unique) {
assert(!addToTables);
Expand Down