Avoid passing context and bundle parameters to directives that don't use them.

[d-ronnqvist]

Bug/issue #, if applicable: rdar://147405751

Summary

This avoids passing the DocumentationContext and DocumentationBundle to directives and semantic analysis that doesn't use it.

It also deprecates the SemanticAnalysis protocol because it's only conformed to but never used as an existential.

Dependencies

None

Testing

Nothing in particular. This isn't a user-facing change.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

• [ ] Added tests
• Ran the ./bin/test script and it succeeded
• [ ] Updated documentation if necessary

[d-ronnqvist]

@swift-ci please test

[anferbui]

Are we able to remove the bundle and context parameter requirement from DirectiveConvertible.init?(from:source:for:in:problems)?

I've had a brief look and it looks like it could be possible, but I'm not sure if there's a layer in which they are required.

Otherwise PR looks good.

[anferbui]

Does this mark the whole type (e.g. Semantic.Analyses.HasAtLeastOne) as deprecated, or does it mark just the functions from the protocol that the conformance is being declared on? Never seen @available used in a protocol extension before :)

[d-ronnqvist]

Because I deprecated the protocol, conforming to it would result in a deprecation warning.

Adding @available(*, deprecated, ...) to the extension that specifies the protocol conformance avoids that deprecation warning without deprecating the entire type (like it would if the conformance was declared in the type definition).

[d-ronnqvist]

Are we able to remove the bundle and context parameter requirement from DirectiveConvertible.init?(from:source:for:in:problems)?

I've had a brief look and it looks like it could be possible, but I'm not sure if there's a layer in which they are required.

I'm tackling that in #1175 which builds on the changes from this PR.

There's no directive that uses the context parameter so we can deprecate that and phase it over a couple of releases. Most directives don't use the bundle parameter either but there are a few that access the bundle's identifier to create ResourceReference values.

[anferbui]

LGTM, thanks for answering my questions!

[d-ronnqvist]

@swift-ci please test

[d-ronnqvist]

@swift-ci please test