Deprecate the context initializer parameter for both MarkupConvertible and DirectiveConvertible
#1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
…iveConvertible` Also, remove or deprecate `context` parameters that were only passed for directives or markup initialization.
d-ronnqvist
force-pushed
the
more-unused-directive-parameters
branch
from
5c9c181 to
fdab6da
Compare
|
@swift-ci please test |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable:
Summary
This builds on #1168 to deprecate the
contextinitializer parameter for bothMarkupConvertibleandDirectiveConvertible.As you can see from the diff, the
contextwas passed around quite a lot but not a single directive convertible or markup convertible type ever accessed the context other than to pass it to the initializer of other directives.Most of these types also don't use the
bundleparameter but a few does access the bundle'sid, so we can't remove the bundle parameter from these protocols.The primary reason for removing the
contextparameter from these protocols is that it allows for them to be created without the context being created first which in the future would them to be created before or during the context's own initialization.Dependencies
None.
Testing
Nothing in particular. This isn't a user facing change.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
AddedUpdated tests./bin/testscript and it succeeded[ ] Updated documentation if necessary