Remove dead, useless storage count check#1647
Open
SiliconA-Z wants to merge 1 commit intoswiftlang:mainfrom
Open
Remove dead, useless storage count check#1647SiliconA-Z wants to merge 1 commit intoswiftlang:mainfrom
SiliconA-Z wants to merge 1 commit intoswiftlang:mainfrom
Conversation
Storage count is always equal to or less than the max, so this is useless dead code.
Contributor
|
@swift-ci please test |
cthielen
reviewed
Jan 13, 2026
|
|
||
| // Effectively O(1), worst case O(n) | ||
| mutating func insert(_ value: Value) -> UInt64 { | ||
| guard storage.count <= UInt64.max else { fatalError("Exceeded maximum storage size") } |
Contributor
There was a problem hiding this comment.
This check is necessary to prevent an infinite loop a few lines down on the while(storage[nextKey] != nil) line.
Since storage.count returns an Int, on 64-bit systems UInt64.max probably won't be reached.
This can be improved but the fatalError is necessary.
cthielen
requested changes
Jan 13, 2026
Contributor
cthielen
left a comment
cthielen
left a comment
There was a problem hiding this comment.
See comment about why the check is necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storage count is always equal to or less than the max, so this is useless dead code.