Skip to content

Remove dead, useless storage count check #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SiliconA-Z wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove dead, useless storage count check #1647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Sources/FoundationEssentials/NotificationCenter/NotificationCenter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ private struct AutoDictionary<Value> {

// Effectively O(1), worst case O(n)
mutating func insert(_ value: Value) -> UInt64 {
guard storage.count <= UInt64.max else { fatalError("Exceeded maximum storage size") }
Copy link
Copy Markdown
Contributor

@cthielen cthielen Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is necessary to prevent an infinite loop a few lines down on the while(storage[nextKey] != nil) line.

Since storage.count returns an Int, on 64-bit systems UInt64.max probably won't be reached.

This can be improved but the fatalError is necessary.


var key = salvagedKeys.popLast()
while(key != nil) {
if let key, storage[key] == nil {
Expand Down