Skip to content

Enable macOS checks in pull request workflow#1729

Draft
shahmishal wants to merge 1 commit intomainfrom
shahmishal-patch-2
Draft

Enable macOS checks in pull request workflow#1729
shahmishal wants to merge 1 commit intomainfrom
shahmishal-patch-2

Conversation

@shahmishal
Copy link
Copy Markdown
Member

Enable macOS checks and update Xcode version.

Enable macOS checks and update Xcode version.
@shahmishal shahmishal requested a review from a team as a code owner February 9, 2026 17:57
@parkera parkera requested a review from jmschonfeld February 9, 2026 17:57
windows_swift_versions: '["nightly-main"]'
enable_macos_checks: false
macos_xcode_versions: '["16.3"]'
enable_macos_checks: true
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this now use the nightly toolchains instead of an Xcode-provided toolchain? Nightly toolchains are required to build swift-foundation

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to move this PR to draft until we have nightly support.

Copy link
Copy Markdown
Contributor

@jmschonfeld jmschonfeld Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run xcrun swift --version
Apple Swift version 6.2.3 (swiftlang-6.2.3.3.21 clang-1700.6.3.2)

It looks like the answer is no - @shahmishal I don't think we can adopt this yet (indeed, the build failed)

@shahmishal shahmishal marked this pull request as draft February 9, 2026 18:01
Copy link
Copy Markdown
Contributor

@parkera parkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops - @jmschonfeld is correct, we need the nightly toolchain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants