Skip to content

Enable macOS checks in pull request workflow #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shahmishal wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Enable macOS checks in pull request workflow #1729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ jobs:
with:
linux_swift_versions: '["nightly-main"]'
windows_swift_versions: '["nightly-main"]'
enable_macos_checks: false
macos_xcode_versions: '["16.3"]'
enable_macos_checks: true
Copy link
Copy Markdown
Contributor

@jmschonfeld jmschonfeld Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this now use the nightly toolchains instead of an Xcode-provided toolchain? Nightly toolchains are required to build swift-foundation

Copy link
Copy Markdown
Member Author

@shahmishal shahmishal Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to move this PR to draft until we have nightly support.

Copy link
Copy Markdown
Contributor

@jmschonfeld jmschonfeld Feb 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Run xcrun swift --version
Apple Swift version 6.2.3 (swiftlang-6.2.3.3.21 clang-1700.6.3.2)

It looks like the answer is no - @shahmishal I don't think we can adopt this yet (indeed, the build failed)

macos_xcode_versions: '["26.2"]'
macos_versions: '["tahoe"]'
enable_wasm_sdk_build: true
wasm_sdk_versions: '["nightly-main"]'
Expand Down
Loading