Fix setAttribute modificationDate on Windows for directories#1855
Merged
jmschonfeld merged 1 commit intoswiftlang:mainfrom Mar 26, 2026
Merged
Conversation
Contributor
Author
|
@swift-ci test |
jakepetroules
approved these changes
Mar 26, 2026
jmschonfeld
reviewed
Mar 26, 2026
- Add missing CreateFileW flag needed for directories. - Adds verification that setAttributes correctly sets and retrieves modification dates on both files and directories.
daveinglis
force-pushed
the
fix_set_modification_time_on_windows
branch
from
4685377 to
f84863e
Compare
Contributor
Author
|
@swift-ci test |
Contributor
|
Should we run a cross-repo test on swift-corelibs-foundation to make sure it doesn't break any tests there? |
Contributor
|
Seems like a good idea to me, I've started that at swiftlang/swift-corelibs-foundation#5441 |
daveinglis
changed the title
Contributor
|
Full toolchain tests have passed as well |
jmschonfeld
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #1854