Skip to content

Fix setAttribute modificationDate on Windows for directories #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmschonfeld merged 1 commit into from
Mar 26, 2026
Merged

Fix setAttribute modificationDate on Windows for directories #1855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/FoundationEssentials/FileManager/FileManager+Files.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -841,7 +841,7 @@ extension _FileManagerImpl {
ftTime.dwLowDateTime = uiTime.LowPart
ftTime.dwHighDateTime = uiTime.HighPart

let hFile: HANDLE = CreateFileW($0, GENERIC_WRITE, FILE_SHARE_WRITE, nil, OPEN_EXISTING, 0, nil)
let hFile: HANDLE = CreateFileW($0, GENERIC_WRITE, FILE_SHARE_WRITE, nil, OPEN_EXISTING, FILE_FLAG_BACKUP_SEMANTICS, nil)
if hFile == INVALID_HANDLE_VALUE {
throw CocoaError.errorWithFilePath(path, win32: GetLastError(), reading: true)
}
Expand Down
21 changes: 21 additions & 0 deletions Tests/FoundationEssentialsTests/FileManager/FileManagerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,6 +886,27 @@ private struct FileManagerTests {
}
}

@Test func testSetAttributesModificationDate() async throws {
try await FilePlayground {
"testFile"
Directory("testDir") {}
}.test { fileManager in
// Test setAttributes with modificationDate on files
let fileTestDate = Date(timeIntervalSince1970: 1234567890)
try fileManager.setAttributes([.modificationDate: fileTestDate], ofItemAtPath: "testFile")
let fileAttrs = try fileManager.attributesOfItem(atPath: "testFile")
let fileModDate = try #require(fileAttrs[.modificationDate] as? Date)
#expect(abs(fileModDate.timeIntervalSince1970 - fileTestDate.timeIntervalSince1970) < 2.0, "File modification date should be set correctly")

// Test setAttributes with modificationDate on directories
let dirTestDate = Date(timeIntervalSince1970: 1234567890)
try fileManager.setAttributes([.modificationDate: dirTestDate], ofItemAtPath: "testDir")
let directoryAttrs = try fileManager.attributesOfItem(atPath: "testDir")
let directoryModDate = try #require(directoryAttrs[.modificationDate] as? Date)
#expect(abs(directoryModDate.timeIntervalSince1970 - dirTestDate.timeIntervalSince1970) < 2.0, "Directory modification date should be set correctly")
}
}

@Test func malformedModificationDateAttribute() async throws {
let sentinelDate = Date(timeIntervalSince1970: 100)
try await FilePlayground {
Expand Down
Loading