Handle mark_dependence_addr in LoadableByAddress - #91413
Open
meg-gupta wants to merge 1 commit into
Open
Conversation
RewriteUser implements visitMarkDependenceInst for the value form of the instruction but had no visitor for the address form, so a mark_dependence_addr whose base is a large loadable value fell through to visitSILInstruction: a "Unimplemented user" fatal error on an asserts build. Rewrite the instruction with the address assigned to its base instead. Encountered while reproducing rdar://172749676
Contributor
Author
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RewriteUser implements visitMarkDependenceInst for the value form of the instruction but had no visitor for the address form, so a mark_dependence_addr whose base is a large loadable value fell through to visitSILInstruction: a "Unimplemented user" fatal error on an asserts build.
Rewrite the instruction with the address assigned to its base instead.
Encountered while reproducing rdar://184166791