Skip to content

Handle mark_dependence_addr in LoadableByAddress #91413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meg-gupta wants to merge 1 commit into
base: main
Choose a base branch
from
+40 −0
Open

Handle mark_dependence_addr in LoadableByAddress #91413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/IRGen/LoadableByAddress.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4790,6 +4790,14 @@ class RewriteUser : SILInstructionVisitor<RewriteUser> {
assignment.markForDeletion(m);
}

void visitMarkDependenceAddrInst(MarkDependenceAddrInst *m) {
auto builder = assignment.getBuilder(m->getIterator());
auto opdAddr = assignment.getAddressForValue(m->getBase());
builder.createMarkDependenceAddr(m->getLoc(), m->getAddress(), opdAddr,
m->dependenceKind());
assignment.markForDeletion(m);
}

void visitStoreInst(StoreInst *store) {
auto builder = assignment.getBuilder(store->getIterator());
SILValue addr = assignment.getAddressForValue(store->getSrc());
Expand Down
32 changes: 32 additions & 0 deletions test/IRGen/loadable_by_address_reg2mem.sil
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,3 +499,35 @@ bb0:
return %ret : $()
}


struct LargeRef {
var c: C1
var p: (Int, Int, Int, Int, Int, Int, Int, Int, Int, Int, Int, Int, Int, Int, Int, Int, Int, Int, Int)
}

// CHECK-LABEL: sil @test_mark_dependence_addr_large_argument
// CHECK: bb0(%0 : $*LargeRef, %1 : $*Builtin.NativeObject):
// CHECK: [[STK:%.*]] = alloc_stack $LargeRef
// CHECK: copy_addr [take] %0 to [init] [[STK]]
// CHECK: mark_dependence_addr [nonescaping] %1 : $*Builtin.NativeObject on [[STK]] : $*LargeRef
// CHECK: } // end sil function 'test_mark_dependence_addr_large_argument'
sil @test_mark_dependence_addr_large_argument : $@convention(thin) (@guaranteed LargeRef, @in_guaranteed Builtin.NativeObject) -> () {
bb0(%0 : $LargeRef, %1 : $*Builtin.NativeObject):
mark_dependence_addr [nonescaping] %1 : $*Builtin.NativeObject on %0 : $LargeRef
%3 = tuple ()
return %3 : $()
}

// CHECK-LABEL: sil @test_mark_dependence_addr_large_loaded_value
// CHECK: bb0(%0 : $*LargeRef, %1 : $*Builtin.NativeObject):
// CHECK-NOT: alloc_stack
// CHECK: mark_dependence_addr [nonescaping] %1 : $*Builtin.NativeObject on %0 : $*LargeRef
// CHECK: } // end sil function 'test_mark_dependence_addr_large_loaded_value'
sil @test_mark_dependence_addr_large_loaded_value : $@convention(thin) (@in_guaranteed LargeRef, @in_guaranteed Builtin.NativeObject) -> () {
bb0(%0 : $*LargeRef, %1 : $*Builtin.NativeObject):
%2 = load %0 : $*LargeRef
mark_dependence_addr [nonescaping] %1 : $*Builtin.NativeObject on %2 : $LargeRef
%4 = tuple ()
return %4 : $()
}