Skip to content

feat(components): update post-popovercontainer animation and fix menu trigger and focus delays #6579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
myrta2302 wants to merge 60 commits into
base: main
Choose a base branch
from
Open

feat(components): update post-popovercontainer animation and fix menu trigger and focus delays #6579

myrta2302 wants to merge 60 commits into from

Conversation

@myrta2302
Copy link
Contributor

@myrta2302 myrta2302 commented Nov 3, 2025 •
edited
Loading

📄 Description

This PR follows #6606:

  • Updates post-popovercontainer to open with animation only when animation is set to 'pop-in'.
  • Updates post-menu to handle focus and aria-expanded on the trigger in postBeforeToggle instead of postToggled, fixing related delays.
  • Updates documentation examples accordingly
  • Enables by default the pop-in animation for the popovercontainer and removes all animation props.

🔮 Design review

  • Design review done
  • No design review needed

📝 Checklist

  • ✅ My code follows the style guidelines of this project
  • 🛠️ I have performed a self-review of my own code
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • ✔️ New and existing unit tests pass locally with my changes

@myrta2302 myrta2302 linked an issue Nov 3, 2025 that may be closed by this pull request
[bug] fix post-menu animation #6538
Open
@changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: bef878a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@swisspost/design-system-components Minor
@swisspost/design-system-components-angular-workspace Minor
@swisspost/design-system-components-react Minor
@swisspost/design-system-documentation Patch
@swisspost/design-system-nextjs-integration Minor
@swisspost/design-system-components-angular Minor
@swisspost/design-system-changelog-github Minor
@swisspost/design-system-eslint Minor
@swisspost/design-system-icons Minor
@swisspost/internet-header Minor
@swisspost/design-system-styles Minor
@swisspost/design-system-styles-primeng-workspace Minor
@swisspost/design-system-styles-primeng Minor
@swisspost/design-system-tokens Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Nov 3, 2025 •
edited
Loading

Related Previews

@myrta2302 myrta2302 changed the title 6538 bug fix post menu animation feat(components): update post-menu animation and fix trigger and focus delays Nov 3, 2025
@myrta2302 myrta2302 marked this pull request as ready for review November 4, 2025 16:10
@myrta2302 myrta2302 requested review from a team as code owners November 4, 2025 16:10
oliverschuerch
oliverschuerch requested changes Nov 5, 2025
View reviewed changes
@myrta2302
Copy link
Contributor Author

myrta2302 commented Nov 27, 2025

Should be merged together with #6617 .

@myrta2302 myrta2302 added the on hold Wait for something to be done, before continue working on this Issue label Nov 27, 2025
@myrta2302 myrta2302 added hold merge Approved but should not be merged yet due to dependencies or a coordinated release. and removed on hold Wait for something to be done, before continue working on this Issue labels Dec 8, 2025
@alizedebray alizedebray removed the hold merge Approved but should not be merged yet due to dependencies or a coordinated release. label Dec 8, 2025
@alizedebray alizedebray added the hold merge Approved but should not be merged yet due to dependencies or a coordinated release. label Dec 8, 2025
@myrta2302 myrta2302 removed the hold merge Approved but should not be merged yet due to dependencies or a coordinated release. label Dec 8, 2025
alizedebray
alizedebray reviewed Dec 8, 2025
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@myrta2302 myrta2302 mentioned this pull request Dec 9, 2025
Open
3 tasks
@myrta2302 myrta2302 added needs: 📃 docs update Something has changed in the design or implementation which needs to be documented accordingly hold merge Approved but should not be merged yet due to dependencies or a coordinated release. and removed needs: 📃 docs update Something has changed in the design or implementation which needs to be documented accordingly labels Dec 9, 2025
@alizedebray alizedebray removed their request for review December 11, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alizedebray alizedebray alizedebray left review comments

@oliverschuerch oliverschuerch oliverschuerch approved these changes

Assignees

No one assigned

Labels

hold merge Approved but should not be merged yet due to dependencies or a coordinated release. 🚂 PR train PR which follows another one.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[bug] fix post-menu animation

5 participants

@myrta2302 @swisspost-bot @oliverschuerch @alizedebray