Ensure proper footer sorting of footer #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Mar 11, 2025
jserv
reviewed
Mar 11, 2025
jserv
reviewed
Mar 11, 2025
charliechiou
force-pushed
the
fix-git-hook
branch
2 times, most recently
from
4ad8e16 to
232546a
Compare
jserv
requested changes
Mar 11, 2025
When no trailer was configured in git configuration, TRAILERS_BY_REGEX remained empty. This caused the subsequent match condition to always evaluate to true, leading to incorrect footer sorting regardless of their content. To address this issue, the update ensures that when the configuration is empty, default terms are used to initialize TRAILERS_BY_REGEX. The sorting mechanism is then adjusted to prioritize other footers, configured trailers, and the change-id. Co-authored-by: EricccTaiwan <[email protected]> Change-Id: I6df5438b7ec6c85f5438f869b44cd14589c03339 Refactor commit trailer regex Refactor commit trailer regex by renaming default_trailers_by to DEFAULT_TRAILERS_BY to follow the naming convention for global variables.Then refine build_commit_trailer_regex by reusing the array. Co-authored-by: EricccTaiwan <[email protected]> Change-Id: I7c7e9367f59a6da0ff84605904d08343ad558f42
charliechiou
force-pushed
the
fix-git-hook
branch
from
232546a to
7381c74
Compare
|
Thank @charliechiou for contributing! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no trailer was configured in git configuration,
TRAILERS_BY_REGEXremained empty. This caused the subsequent match condition to always evaluate to true, leading to incorrect footer sorting regardless of their content.To address this issue, the update ensures that when the configuration is empty, default terms are used to initialize
TRAILERS_BY_REGEX. The sorting mechanism is then adjusted to prioritize other footers, configured trailers, and the change-id.Change-Id: I6df5438b7ec6c85f5438f869b44cd14589c03339