-
Notifications
You must be signed in to change notification settings - Fork 848
feat: Add 'select using items' functionality for selecting commands #2078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Add 'select using items' functionality for selecting commands #2078
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds three new voice commands to enable selecting text using the "items" keyword, providing an alternative selection interface based on quantity and direction. These commands use simple keyboard shortcuts (shift + arrow keys) with repetition to perform the selection.
Key Changes
- Added
<number_small> items:command to select multiple items downward - Added
left <number_small> items:andright <number_small> items:commands for horizontal selection
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Select Using the Items Keyword | ||
| <number_small> items: | ||
| key(shift-down) | ||
| repeat(number_small - 1) |
Copilot
AI
Dec 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spacing around the minus operator is inconsistent with the codebase style. Other uses of repeat in the repository use spaces around the minus operator, such as in core/modes/dictation_mode.talon. This should be changed to repeat(number_small - 1) for consistency.
| repeat(number_small - 1) | ||
| left <number_small> items: | ||
| key(shift-left) | ||
| repeat(number_small - 1) |
Copilot
AI
Dec 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spacing around the minus operator is inconsistent with the codebase style. Other uses of repeat in the repository use spaces around the minus operator, such as in core/modes/dictation_mode.talon. This should be changed to repeat(number_small - 1) for consistency.
| repeat(number_small - 1) | ||
| right <number_small> items: | ||
| key(shift-right) | ||
| repeat(number_small - 1) |
Copilot
AI
Dec 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spacing around the minus operator is inconsistent with the codebase style. Other uses of repeat in the repository use spaces around the minus operator, such as in core/modes/dictation_mode.talon. This should be changed to repeat(number_small - 1) for consistency.
This pull request adds new voice commands to the
text_navigation.talonfile that allow users to select multiple items using the "items" keyword. These commands provide an alternative way to select text by specifying a quantity and direction.New selection commands:
<number_small> items:command to select multiple items downward usingshift-downand repeat for the specified count.left <number_small> items:andright <number_small> items:commands to select multiple items to the left or right usingshift-leftandshift-right, repeating for the specified count.