-
Notifications
You must be signed in to change notification settings - Fork 848
feat: Add 'select using items' functionality for selecting commands #2078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -81,3 +81,14 @@ big word neck [<number_small>]: | |
| user.navigation_by_name("SELECT", "RIGHT", "DEFAULT", "big", number_small or 1) | ||
| big word pre [<number_small>]: | ||
| user.navigation_by_name("SELECT", "LEFT", "DEFAULT", "big", number_small or 1) | ||
|
|
||
| # Select Using the Items Keyword | ||
| <number_small> items: | ||
| key(shift-down) | ||
| repeat(number_small - 1) | ||
| left <number_small> items: | ||
| key(shift-left) | ||
| repeat(number_small - 1) | ||
|
||
| right <number_small> items: | ||
| key(shift-right) | ||
| repeat(number_small - 1) | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spacing around the minus operator is inconsistent with the codebase style. Other uses of repeat in the repository use spaces around the minus operator, such as in core/modes/dictation_mode.talon. This should be changed to
repeat(number_small - 1)for consistency.