Update README.md#7
Open
smorimoto wants to merge 2 commits into
Open
Conversation
Signed-off-by: Sora Morimoto <sora@morimoto.io>
Leonidas-from-XIV
requested changes
Aug 6, 2024
Leonidas-from-XIV
left a comment
Leonidas-from-XIV
left a comment
Member
There was a problem hiding this comment.
Thanks, I have one small change I'd like to have before merging.
| Check-Changelog: | ||
| name: Check Changelog Action | ||
| runs-on: ubuntu-20.04 | ||
| runs-on: ubuntu-latest |
Member
There was a problem hiding this comment.
Generally I'd prefer not to push people to setups that might break, so I'd rather have a fixed version here.
There was a problem hiding this comment.
For such a simple action it should be fine to use ubuntu-latest. Usually the jobs are independent, I don't think anyone is going add more steps after the changelog action, so they'll use their preferred OS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.