Skip to content
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Add this to your GitHub workflow:

```yaml
- name: Check changelog
uses: tarides/changelog-check-action@v2
uses: tarides/changelog-check-action@v3
```

### Full example
Expand All @@ -52,15 +52,14 @@ A complete `.github/workflows/changelog.yml` might look like this:
name: Check Changelog
on:
pull_request:
types: [assigned, opened, synchronize, reopened, labeled, unlabeled]
branches:
- main
types: [assigned, labeled, opened, reopened, synchronize, unlabeled]
branches: [main]
jobs:
Check-Changelog:
name: Check Changelog Action
runs-on: ubuntu-20.04
runs-on: ubuntu-latest

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally I'd prefer not to push people to setups that might break, so I'd rather have a fixed version here.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For such a simple action it should be fine to use ubuntu-latest. Usually the jobs are independent, I don't think anyone is going add more steps after the changelog action, so they'll use their preferred OS.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

steps:
- uses: tarides/changelog-check-action@v2
- uses: tarides/changelog-check-action@v3
with:
changelog: CHANGES.md
```