Version refractor#69
Open
abdelmounaimTA wants to merge 37 commits into
Open
Conversation
Fix attributes dictionary in GTFEntry
In Python 3, getSequenceVariants is no longer deterministic. Polymorphisms are stored in sets. Since Python 3.3, python randomizes hash keys of sets for a security reason (https://stackoverflow.com/questions/14956313/why-is-dictionary-ordering-non-deterministic). This means that the iteration order might be different every time. I propose a simple sort before iteration of alleles so the output of getSequenceVariants becomes deterministic. There is also a small change in the encode method to fix the edge case where a stop variant is present at the end of the sequence. In this case, the sequence is SEQUENCEV/ instead of SEQUENCEV/*.
Deterministic version of getSequenceVariants
Updated Copyright to 2020.
Make 3.5 the official python version
…l-3.5 Conflicts: README.rst
Fixed bug in python version check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.