feat(linux): allow disabling WebViewUriLoader via feature#1562
feat(linux): allow disabling WebViewUriLoader via feature#1562dgerhardt wants to merge 1 commit into
Conversation
0e9f281 to
a262a4b
Compare
Package Changes Through a262a4bThere are 1 changes which include wry with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
A new feature flag `linux-request-queue` has been introduced, which is enabled by default to keep the previous behavior. The `WebViewUriLoader` is a workaround for an unknown bug but disabling it can be useful because * it introduces a deadlock situation, and * the bug might no longer exist in newer WebKitGTK versions. Refs tauri-apps/tauri#12589 Refs tauri-apps#359
a262a4b to
d16c451
Compare
|
shouldn't this be done via a configuration in the webview attributes instead of a feature flag? |
|
it's also a pretty feature creepy config anyway |
|
@lucasfernog I've used a feature under the assumption that the marked code is a preparation for a complete removal in the future when the underlying Webkit2GTK issue has been fixed. If you think that a webview attribute would be more appropriate in this case, I'm happy to adjust the PR. |
|
I had a look at implementing this using |
|
can you check if the deadlock is still happening? i don't see much value in this kind of config, it's a bit too much IMO |
|
I ran the reproduction against the dev branch and the deadlock now is no longer consistently reproducible, but it still occurs in rare cases. I get around one case of a deadlock when running the reproduction 20 times.
Since the issue the workaround is supposed to fix isn't well documented (there is no reproduction code or linked GH issue), it is hard to tell if it still exists. So instead of removing it directly, I used a feature flag for opting out to allow more testing before a removal. But I've done a lot of testing with the workaround removed and opening a lot of webviews in parallel and could not reproduce the bug (tested on Ubuntu 24.04 using |
|
@lucasfernog I've opened #1605, which removes the workaround instead of introducing a new feature flag. |
|
Closing this since #1605 has been merged. |
A new feature flag
linux-request-queuehas been introduced, which is enabled by default to keep the previous behavior.The
WebViewUriLoaderis a workaround for an unknown bug but disabling it can be useful becauseRefs tauri-apps/tauri#12589
Refs #359