fix(linux): remove harmful request loading workaround#1605
Conversation
Package Changes Through 12a48eeThere are 1 changes which include wry with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
The `WebViewUriLoader` is a workaround for an unknown concurrency bug in WebKitGTK. It is now removed because * it introduces a deadlock situation, * it disables parallel loading when initializing multiple webviews, and * the bug can no longer be reproduced using current WebKitGTK versions. Closes tauri-apps/tauri#12589 Refs tauri-apps#359
ca0c1b2 to
8188d35
Compare
lucasfernog
left a comment
There was a problem hiding this comment.
looks like it still works, let's see if something comes up.
@chippers please let us know if you still can reproduce the bug or if you have a reproduction example out there still :D
i think i have a video of it, because i remember making a video of my test case opening dozens of windows in a tiling manner on my 4k monitor to try and reproduce it (only sometimes), but it's been so long idk where it is or the test suite i made for it. if i find it ill post it but if it's no longer needed, that's good :) |
With the introduction of the multi webview unstable feature in #359, a workaround for request loading during webview initialization was added for an unknown concurrency bug in WebKitGTK. This PR now removes it because it has negative side effects and does not seem to be needed anymore:
The workaround does not seem to have ever been intended to be a long term solution (FIXME comment). Unfortunately, there is no issue linked for the underlying issue and no reproduction was provided, which makes it hard to tell if the bug still exists with newer versions of WebKitGTK. But I have not been able to reproduce the issue on Ubuntu 24.04 using
libwebkit2gtk-4.1-0@2.48.3-0ubuntu0.24.04.1. In the worst case scenario, this would cause a regression on an unstable feature while still fixing and improving webview loading in general on Linux.This PR provides an alternate solution for #1562, which instead introduces a feature flag to opt out of the workaround.
Original description of the workaround:
Closes tauri-apps/tauri#12589
Refs #359