Skip to content

Add a HostHook to account for internal method overriding #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgaudet merged 15 commits into from
Jul 22, 2026
Merged

Add a HostHook to account for internal method overriding #19

Changes from 3 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b2b3a1f
Host Hook attempt One
mgaudet Jul 20, 2026
51a901e
Explicitly call out module namesapce objects
mgaudet Jul 20, 2026
29be1b9
Correct missed period
mgaudet Jul 20, 2026
fa8d9cd
Identify Module Namespace Objects by their internal slots
mgaudet Jul 20, 2026
9382ec7
Remove no longer needed note
mgaudet Jul 20, 2026
63b6b6d
Address review feedback
mgaudet Jul 20, 2026
668d276
Add missing ins
mgaudet Jul 20, 2026
8035b91
Reword
mgaudet Jul 20, 2026
714b840
Ensure host hook does not run user code
mgaudet Jul 21, 2026
bf19309
Address typos
mgaudet Jul 21, 2026
354eb0f
Update name of descriptor fields
mgaudet Jul 21, 2026
e4f39cd
Check for null-prototype before recursing
mgaudet Jul 21, 2026
1b0c778
re-order HostObjectHasImpureLookupInternalMethod
mgaudet Jul 21, 2026
9efeae7
Identify proxies by internal methods
mgaudet Jul 21, 2026
bba0cca
punctuation
mgaudet Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 38 additions & 1 deletion spec.emu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ contributors: Matthew Gaudet, Justin Ridgewell
<emu-alg>
1. <ins>If _o_ is *null*, return *false*.</ins>
Comment thread
mgaudet marked this conversation as resolved.
Outdated
1. <ins>If _o_ has a [[ProxyHandler]] internal slot, return *true*.</ins>
1. <ins>If _o_ uses different steps than the ordinary object steps for [[GetPrototypeOf]] or [[GetOwnProperty]], return *true*.</ins>
1. <ins>If HostObjectHasImpureLookupInternalMethods(_o_) returns *true*, return *true*.</ins>
Comment thread
mgaudet marked this conversation as resolved.
Outdated
1. <ins>if _o_ is a Module Namespace Object, return *true*.</ins>
Comment thread
mgaudet marked this conversation as resolved.
Outdated
1. <ins>Let _desc_ be _o_.[[GetOwnProperty]](_propertyKey_).</ins>
Comment thread
mgaudet marked this conversation as resolved.
Outdated
1. <ins>If _desc_ is not *undefined*, then</ins>
1. <ins>If _desc_ has a [[Get]] field and kind is ~any~ or ~get~, return *true*.</ins>
Expand Down Expand Up @@ -226,3 +227,39 @@ contributors: Matthew Gaudet, Justin Ridgewell
</emu-clause>
</emu-clause>
</emu-clause>

<emu-clause id="sec-hosthasinternalmethodswhichcanrunusercode" type="host-defined abstract operation">
<h1>
HostObjectHasImpureLookupInternalMethods (
_object_: A job
Comment thread
mgaudet marked this conversation as resolved.
Outdated
): a boolean
Comment thread
mgaudet marked this conversation as resolved.
Outdated
</h1>
<dl class="header">
<dt>description</dt>
<dd>Indicates if a host object overrides the methods [[GetOwnProperty]] or [[GetPrototypeOf]] in such a way that user code could run.</dd>
</dl>

<p>An implementation of HostObjectHasImpureLookupInternalMethods should return *true* if the given object is a host defined object with its own definition of [[GetOwnProperty]] or [[GetPrototypeOf]] such that
user code could run</p>
Comment thread
mgaudet marked this conversation as resolved.
Outdated
Comment thread
mgaudet marked this conversation as resolved.
Outdated
</emu-clause>

<emu-annex id="sec-host-hooks-summary">
<h1>Host Hooks</h1>
<p><b>HostCallJobCallback(...)</b></p>
<p><b>HostEnqueueFinalizationRegistryCleanupJob(...)</b></p>
<p><b>HostEnqueueGenericJob(...)</b></p>
<p><b>HostEnqueuePromiseJob(...)</b></p>
<p><b>HostEnqueueTimeoutJob(...)</b></p>
<p><b>HostEnsureCanCompileStrings(...)</b></p>
<p><b>HostFinalizeImportMeta(...)</b></p>
<p><b>HostGetImportMetaProperties(...)</b></p>
<p><b>HostGrowSharedArrayBuffer(...)</b></p>
<p><b>HostHasSourceTextAvailable(...)</b></p>
<p><b>HostLoadImportedModule(...)</b></p>
<p><b>HostGetSupportedImportAttributes(...)</b></p>
<p><b>HostMakeJobCallback(...)</b></p>
<p><b>HostPromiseRejectionTracker(...)</b></p>
<p><b>HostResizeArrayBuffer(...)</b></p>
<p><b>InitializeHostDefinedRealm(...)</b></p>
<ins><p><b>HostObjectHasImpureLookupInternalMethods(...)</b></p></ins>
</emu-annex>
Loading