Conversation
bakkot
reviewed
Jul 20, 2026
Collaborator
Author
|
@tc39/ecma262-editors Here's the host-hook patch to look over |
bakkot
approved these changes
Jul 20, 2026
jridgewell
approved these changes
Jul 22, 2026
nicolo-ribaudo
approved these changes
Jul 22, 2026
nicolo-ribaudo
left a comment
nicolo-ribaudo
left a comment
Member
There was a problem hiding this comment.
Probably not going to be present for the discussion of this, but lgtm for stage 2.7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has a second commit which explicitly excludes module namespace objects (which would not be covered by the host hook)