-
Notifications
You must be signed in to change notification settings - Fork 2
Add a HostHook to account for internal method overriding #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b2b3a1f
Host Hook attempt One
mgaudet 51a901e
Explicitly call out module namesapce objects
mgaudet 29be1b9
Correct missed period
mgaudet fa8d9cd
Identify Module Namespace Objects by their internal slots
mgaudet 9382ec7
Remove no longer needed note
mgaudet 63b6b6d
Address review feedback
mgaudet 668d276
Add missing ins
mgaudet 8035b91
Reword
mgaudet 714b840
Ensure host hook does not run user code
mgaudet bf19309
Address typos
mgaudet 354eb0f
Update name of descriptor fields
mgaudet e4f39cd
Check for null-prototype before recursing
mgaudet 1b0c778
re-order HostObjectHasImpureLookupInternalMethod
mgaudet 9efeae7
Identify proxies by internal methods
mgaudet bba0cca
punctuation
mgaudet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.