Port appdata to AppStream 1.0 #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a key=value dict, with two entries one gets an error:
E: com.github.tchx84.Flatseal:39: custom-key-duplicated Purism::form_factor
A key can only be used once.
Apps generally remove the workstation key so the app is still marked as
mobile capable.
|
Hey @A6GibKm , thank you! Ill check this ASAP and that other link 🙌 |
A6GibKm
commented
Mar 5, 2024
| @@ -32,10 +33,12 @@ | |||
| <update_contact>[email protected]</update_contact> | |||
| <!-- TRANSLATORS: Don't translate this text --> | |||
| <developer_name>Martin Abente Lahaye</developer_name> | |||
| <developer id="com.github.tchx84"> | |||
| <name translatable="no">Martin Abente Lahaye</name> | |||
There was a problem hiding this comment.
I set this as translatable="no" based on the line above. Alternatively I could offer one of:
- Set the other as translatable="no" too and remove its comment
- Remove translatable="no" from this one, the comment will appear anyways in the .po file due to how gettext works (as long as it remains on top of the string above).
While there is no consensus on the matter, there is an argument in favor of allowing translations. It might be useful to provide a transliteration in certain languages.
tchx84
requested changes
Mar 9, 2024
developer_name was deprecated in AppStream 1.0, this is the replacement.
Fixes the following error:
com.github.tchx84.Flatseal:~: desktop-app-launchable-missing
This `desktop-application` component is missing a `desktop-id` launchable tag. This means that
this application can not be launched and has no association with its desktop-entry file. It also
means no icon data or category information from the desktop-entry file will be available, which
will result in this application being ignored entirely.
tchx84
approved these changes
Mar 11, 2024
|
thank you @A6GibKm !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for updating the app at Flathub as of a few weeks ago.