Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port appdata to AppStream 1.0 #660

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Port appdata to AppStream 1.0 #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9875855
appdata: Remove Purism::form_factor=workstation
A6GibKm Mar 3, 2024
68a0604
appdata: Add developer tag
A6GibKm Mar 3, 2024
245f341
appdata: Add launchable
A6GibKm Mar 3, 2024
ad2cec0
meson: Switch tests to appstreamcli
A6GibKm Mar 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion data/com.github.tchx84.Flatseal.appdata.xml.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<!-- TRANSLATORS: Don't translate this text -->
<name>Flatseal</name>
<id>com.github.tchx84.Flatseal</id>
<launchable type="desktop-id">com.github.tchx84.Flatseal.desktop</launchable>
<metadata_license>CC0-1.0</metadata_license>
<project_license>GPL-3.0-or-later</project_license>
<content_rating type="oars-1.1"/>
Expand Down Expand Up @@ -32,10 +33,12 @@
<update_contact>[email protected]</update_contact>
<!-- TRANSLATORS: Don't translate this text -->
<developer_name>Martin Abente Lahaye</developer_name>
<developer id="dev.tchx84">
<name translatable="no">Martin Abente Lahaye</name>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set this as translatable="no" based on the line above. Alternatively I could offer one of:

  • Set the other as translatable="no" too and remove its comment
  • Remove translatable="no" from this one, the comment will appear anyways in the .po file due to how gettext works (as long as it remains on top of the string above).

While there is no consensus on the matter, there is an argument in favor of allowing translations. It might be useful to provide a transliteration in certain languages.

</developer>
<url type="homepage">https://github.com/tchx84/flatseal</url>
<url type="bugtracker">https://github.com/tchx84/flatseal/issues</url>
<custom>
<value key="Purism::form_factor">workstation</value>
<value key="Purism::form_factor">mobile</value>
</custom>
</component>
8 changes: 4 additions & 4 deletions data/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ appstream_file = i18n.merge_file(
install_dir: join_paths(get_option('datadir'), 'appdata')
)

appstream_util = find_program('appstream-util', required: false)
if appstream_util.found()
test('Validate appstream file', appstream_util,
args: ['validate', appstream_file]
appstreamcli = find_program('appstreamcli', required: false)
if appstreamcli.found()
test('Validate appstream file', appstreamcli,
args: ['validate', '--no-net', '--explain', appstream_file]
)
endif

Expand Down