Add efibootmgr script #3645
Add efibootmgr script #3645
Conversation
martinhoyer
added
the
status | blocked
martinhoyer
force-pushed
the
efibootmgr-script
branch
from
6a82bf3 to
c6050d8
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| # Configure next boot | ||
| logger -s "Setting next boot entry to $os_boot_entry" | ||
| efibootmgr -n $os_boot_entry |
Check notice
Code scanning / shellcheck
Double quote to prevent globbing and word splitting. Note
| @@ -16,6 +16,12 @@ results are represented as ``<testsuite>`` tags, each containing a | |||
| ``<testcase>`` tag for the main result, along with additional | |||
| ``<testcase>`` tags for any subresults. | |||
|
|
|||
| A new ``tmt-ensure-efiboot-order`` script has been added to help manage | |||
There was a problem hiding this comment.
What about using a bit more generic name such as tmt-boot-order or tmt-set-boot-order? Not sure if there are (or will be) more similar use cases, but the currently proposed name sounds very specific to efiboot. Perhaps, in the future, we would like to support not only preserving the current one but setting a specific one? Just brainstorming...
There was a problem hiding this comment.
yep, @psss you are the naming expert :)
| fi | ||
|
|
||
| # Get current boot entry | ||
| os_boot_entry=$(efibootmgr | awk '/BootCurrent/ { print $2 }') |
There was a problem hiding this comment.
Seems we already have a similar code in the tmt-reboot script:
tmt/tmt/steps/execute/scripts/tmt-reboot
Lines 25 to 39 in 434cbe1
Possibly it would make sense to keep it at one place and share?
There was a problem hiding this comment.
Could be, I just thought it would be good to have it fully independent, but no preference, especially if we'll be copying all scripts at once to guests.
Requires #3396
Pull Request Checklist