Drop BaseResult.show() method, it is no longer needed - #5026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the show methods from the BaseResult and Result classes in tmt/result.py. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
happz
force-pushed
the
results-drop-show
branch
from
August 20, 2026 13:33
3c648fc to
0f139c3
Compare
Contributor
Author
|
/packit build |
happz
force-pushed
the
results-drop-show
branch
from
August 21, 2026 15:36
0f139c3 to
34f558c
Compare
BaseResult.show() method, it is no longer needed
psss
approved these changes
Aug 24, 2026
therazix
approved these changes
Aug 24, 2026
psss
force-pushed
the
results-drop-show
branch
from
August 24, 2026 14:12
34f558c to
6ab7c10
Compare
bajertom
approved these changes
Aug 24, 2026
It was used by the `report/display` plugin, but we moved to nicer templates instead, releaving results from the responsibility for their own presentation.
therazix
force-pushed
the
results-drop-show
branch
from
September 1, 2026 07:37
6ab7c10 to
77a9a6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was used by the
report/displayplugin, but we moved to nicer templates instead, releaving results from the responsibility for their own presentation.Pull Request Checklist