Skip to content

Drop BaseResult.show() method, it is no longer needed - #5026

Merged
therazix merged 1 commit into
mainfrom
results-drop-show
Sep 1, 2026
Merged

Drop BaseResult.show() method, it is no longer needed#5026
therazix merged 1 commit into
mainfrom
results-drop-show

Conversation

@happz

@happz happz commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

It was used by the report/display plugin, but we moved to nicer templates instead, releaving results from the responsibility for their own presentation.

Pull Request Checklist

  • implement the feature

@happz happz added this to planning Jul 1, 2026
@happz happz added code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. area | results Related to how tmt stores and shares results ci | full test Pull request is ready for the full test execution labels Jul 1, 2026
@github-project-automation github-project-automation Bot moved this to backlog in planning Jul 1, 2026
@happz happz moved this from backlog to implement in planning Jul 1, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the show methods from the BaseResult and Result classes in tmt/result.py. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@happz happz moved this from implement to review in planning Jul 1, 2026
@happz
happz force-pushed the results-drop-show branch from 3c648fc to 0f139c3 Compare August 20, 2026 13:33
@happz happz added the status | blocking other work An important pull request, blocking other pull requests or issues label Aug 20, 2026
@happz

happz commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

/packit build

@happz
happz force-pushed the results-drop-show branch from 0f139c3 to 34f558c Compare August 21, 2026 15:36
@psss psss changed the title Drop BaseResult.show() method, it is no longer needed Drop BaseResult.show() method, it is no longer needed Aug 24, 2026
@psss
psss requested review from bajertom and therazix August 24, 2026 13:20
@psss psss moved this from review to merge in planning Aug 24, 2026
@psss
psss force-pushed the results-drop-show branch from 34f558c to 6ab7c10 Compare August 24, 2026 14:12
@therazix therazix added this to the 1.79 milestone Aug 27, 2026
It was used by the `report/display` plugin, but we moved to nicer
templates instead, releaving results from the responsibility for their
own presentation.
@therazix
therazix merged commit d03d484 into main Sep 1, 2026
34 checks passed
@therazix
therazix deleted the results-drop-show branch September 1, 2026 13:07
@github-project-automation github-project-automation Bot moved this from merge to done in planning Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area | results Related to how tmt stores and shares results ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. status | blocking other work An important pull request, blocking other pull requests or issues

Projects

Status: done

Development

Successfully merging this pull request may close these issues.

4 participants