Skip to content

Drop BaseResult.show() method, it is no longer needed #5026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
therazix merged 1 commit into from
Sep 1, 2026
+0 −41
Merged

Drop BaseResult.show() method, it is no longer needed #5026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 0 additions & 41 deletions tmt/result.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,23 +213,6 @@ class BaseResult(SerializableContainer):
def __post_init__(self) -> None:
self.original_result = self.result

def show(self) -> str:
"""
Return a nicely colored result with test name (and note)
"""

result = 'errr' if self.result == ResultOutcome.ERROR else self.result.value

components: list[str] = [
style(result, fg=RESULT_OUTCOME_COLORS[self.result]),
self.name,
]

if self.note:
components.append(f'({self.printable_note})')

return ' '.join(components)

@property
def printable_note(self) -> str:
return ', '.join(self.note)
Expand Down Expand Up @@ -573,30 +556,6 @@ def summary(results: list['Result']) -> str:
# FIXME: cast() - https://github.com/teemtee/fmf/issues/185
return cast(str, fmf.utils.listed(comments or ['no results found']))

def show(self, display_guest: bool = True) -> str:
"""
Return a nicely colored result with test name (and note)
"""

from tmt.guest import format_guest_full_name

result = 'errr' if self.result == ResultOutcome.ERROR else self.result.value

components: list[str] = [
style(result, fg=RESULT_OUTCOME_COLORS[self.result]),
self.name,
]

if display_guest and self.guest:
assert self.guest.name # narrow type

components.append(f'(on {format_guest_full_name(self.guest.name, self.guest.role)})')

if self.note:
components.append(f'({self.printable_note})')

return ' '.join(components)

@property
def failure_logs(self) -> list[Path]:
"""
Expand Down
Loading