fix panic when trying to read pod logs when pod is already deleted

[huntlyroad]

Changes

fixed panic when trying to call log.NewReader(logType, opts) for a pipelineRun, but some of the task pod has been deleted.

Release Notes

fix panic when trying to read pod logs when pod is already deleted

[linux-foundation-easycla]

• ✅login: huntlyroad / (3c30d7c)

The committers listed above are authorized under a signed CLA.

[tekton-robot]

Hi @huntlyroad. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pratap0007]

/ok-to-test

[piyush-garg]

@huntlyroad You need to sign the CLA

[huntlyroad]

@piyush-garg CLA has been signed.

[vdemeester]

cc @piyush-garg @PuneetPunamiya

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[piyush-garg]

/release-note fix panic when trying to read pod logs when pod is already deleted

[piyush-garg]

/lgtm

[piyush-garg]

/lgtm cancel

[piyush-garg]

@huntlyroad can we think of putting a message in logs, like pod not found etc? Will it add more value, instead of just showing no logs

[huntlyroad]

@piyush-garg surely we can, I was busy with other project, did this quick fix. Let me check later

[divyansh42]

@huntlyroad, in case you have some time to update the PR so that we can merge it. Thank you.

[divyansh42]

This can be critical for the users. Due to inactivity, taking up the required follow-up changes here #2595

[tekton-robot]

@huntlyroad: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.