-
Notifications
You must be signed in to change notification settings - Fork 264
fix panic when trying to read pod logs when pod is already deleted #2595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/hold |
Signed-off-by: divyansh42 <[email protected]>
1fbbedb
to
c370dd6
Compare
/hold cancel |
/cc @piyush-garg |
/lgtm |
Hi @divyansh42, can you please add the steps to reproduce this? |
The case that is fixed in the PR is very rare, and I guess this can be reproduced in a very tight scenario where the pod is pruned just after it is received in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vinamra28 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
fixed panic when trying to call log.NewReader(logType, opts) for a pipelineRun, but some of the task pod has been deleted.
Initial work is done in #2411, due to inactivity taking up the follow up changes
/kind bug
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make check
make generated
See the contribution guide
for more details.
Release Notes