Skip to content

Conversation

divyansh42
Copy link
Member

@divyansh42 divyansh42 commented Aug 19, 2025

Changes

fixed panic when trying to call log.NewReader(logType, opts) for a pipelineRun, but some of the task pod has been deleted.

Initial work is done in #2411, due to inactivity taking up the follow up changes

/kind bug

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

fix panic when trying to read pod logs when pod is already deleted

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Aug 19, 2025
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 19, 2025
@divyansh42
Copy link
Member Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2025
@divyansh42
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2025
@divyansh42
Copy link
Member Author

/cc @piyush-garg

@pratap0007
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2025
@vinamra28
Copy link
Member

Hi @divyansh42, can you please add the steps to reproduce this?

@divyansh42
Copy link
Member Author

Hi @divyansh42, can you please add the steps to reproduce this?

The case that is fixed in the PR is very rare, and I guess this can be reproduced in a very tight scenario where the pod is pruned just after it is received in the podC channel. I have tried to reproduce that, but unfortunately couldn't get it done. Just modified a few more things, like the continue statement and error messages based on my understanding and based on the initial PR from the user.

Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2025
@tekton-robot tekton-robot merged commit 84d0c59 into tektoncd:main Aug 21, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants