Skip to content

fix: replace kodata LICENSE symlinks with actual files#10358

Merged
tekton-robot merged 2 commits into
tektoncd:mainfrom
khrm:fix-kodata-symlinks
Jun 29, 2026
Merged

fix: replace kodata LICENSE symlinks with actual files#10358
tekton-robot merged 2 commits into
tektoncd:mainfrom
khrm:fix-kodata-symlinks

Conversation

@khrm

@khrm khrm commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

ko v0.19.0 introduced strict enforcement that kodata symlinks must not resolve outside the kodata root (ko-build/ko#1619). The existing LICENSE -> ../../../LICENSE symlinks in all cmd/*/kodata/ directories resolve to the repo root, which ko now rejects when tarring for any non-kind registry (including CI).

Replace the symlinks with actual copies of the LICENSE file.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Fixes #10357

Release Notes

NONE

@khrm @claude
fix: replace kodata LICENSE symlinks with actual files
4aab3fd 
ko v0.19.0 introduced strict enforcement that kodata symlinks must not
resolve outside the kodata root (ko-build/ko#1619). The existing
LICENSE -> ../../../LICENSE symlinks in all cmd/*/kodata/ directories
resolve to the repo root, which ko now rejects when tarring for any
non-kind registry (including CI).

Replace the symlinks with actual copies of the LICENSE file.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jun 29, 2026
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 29, 2026
@khrm

khrm commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jun 29, 2026
khrm
khrm commented Jun 29, 2026
View reviewed changes

@khrm khrm left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @vdemeester

@waveywaves

waveywaves commented Jun 29, 2026

Copy link
Copy Markdown
Member

cc @khrm CI is failing

@khrm @claude
ci: pin ko to v0.18.1 to avoid v0.19.0 regressions
dcf4889 
ko v0.19.0 introduced two breaking changes:
1. Strict kodata symlink enforcement (ko-build/ko#1619)
2. A YAML encoder error when a label selector filters all documents
   in a file (fixed in ko-build/ko fix-empty-docnodes-encoder-close)

Pin to v0.18.1 as a temporary workaround until ko releases a fixed
version. The kodata symlinks are also fixed in this branch.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@khrm

khrm commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

We need to revert dcf4889 after my fix in ko is merged.

@khrm

khrm commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

/retest

khrm
khrm commented Jun 29, 2026
View reviewed changes

@khrm khrm left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@waveywaves

waveywaves commented Jun 29, 2026

Copy link
Copy Markdown
Member

/retest

afrittoli
afrittoli reviewed Jun 29, 2026
View reviewed changes
Comment thread .github/workflows/ci.yaml
Comment on lines +186 to +187
with:
version: v0.18.1

@afrittoli afrittoli Jun 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to pin to v0.18.1 given that links have been replaced with files?
It's probably good to pin in any case, but shouldn't we able to pin v0.19 then?

@khrm khrm Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for now until ko with ko-build/ko#1694 is released

waveywaves
waveywaves approved these changes Jun 29, 2026
View reviewed changes

@waveywaves waveywaves left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2026
@tekton-robot

tekton-robot commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: waveywaves

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2026
@tekton-robot tekton-robot merged commit fcd1e0c into tektoncd:main Jun 29, 2026
42 of 44 checks passed
@khrm khrm deleted the fix-kodata-symlinks branch June 29, 2026 17:48
@waveywaves waveywaves mentioned this pull request Jun 30, 2026
Merged
6 tasks
@vdemeester

vdemeester commented Jul 2, 2026

Copy link
Copy Markdown
Member

/cherry-pick release-v1.3.x release-v1.6.x release-v1.9.x release-v1.12.x

@tekton-robot

tekton-robot commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

✅ Cherry-pick to release-v1.3.x successful!

A new pull request has been created to cherry-pick this change to release-v1.3.x.

PR: #10387

Please review and merge the cherry-pick PR.

@tekton-robot

tekton-robot commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

✅ Cherry-pick to release-v1.6.x successful!

A new pull request has been created to cherry-pick this change to release-v1.6.x.

PR: #10385

Please review and merge the cherry-pick PR.

@tekton-robot

tekton-robot commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

✅ Cherry-pick to release-v1.12.x successful!

A new pull request has been created to cherry-pick this change to release-v1.12.x.

PR: #10386

Please review and merge the cherry-pick PR.

This was referenced Jul 2, 2026
Open
Merged
@tekton-robot tekton-robot mentioned this pull request Jul 2, 2026
Merged
8 tasks
@tekton-robot

tekton-robot commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

✅ Cherry-pick to release-v1.9.x successful!

A new pull request has been created to cherry-pick this change to release-v1.9.x.

PR: #10388

Please review and merge the cherry-pick PR.

@tekton-robot tekton-robot mentioned this pull request Jul 2, 2026
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afrittoli afrittoli afrittoli left review comments
@waveywaves waveywaves waveywaves approved these changes
@pritidesai pritidesai Awaiting requested review from pritidesai
@twoGiants twoGiants Awaiting requested review from twoGiants

Assignees

@vdemeester vdemeester

@waveywaves waveywaves

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI broken by ko v0.19.0 — kodata LICENSE symlinks escape kodata root

5 participants

@khrm @waveywaves @tekton-robot @vdemeester @afrittoli