[cherry-pick: release-v1.6.x] fix: replace kodata LICENSE symlinks with actual files#10385
Open
tekton-robot wants to merge 2 commits into
Open
[cherry-pick: release-v1.6.x] fix: replace kodata LICENSE symlinks with actual files#10385tekton-robot wants to merge 2 commits into
tekton-robot wants to merge 2 commits into
Conversation
ko v0.19.0 introduced strict enforcement that kodata symlinks must not resolve outside the kodata root (ko-build/ko#1619). The existing LICENSE -> ../../../LICENSE symlinks in all cmd/*/kodata/ directories resolve to the repo root, which ko now rejects when tarring for any non-kind registry (including CI). Replace the symlinks with actual copies of the LICENSE file. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
ko v0.19.0 introduced two breaking changes: 1. Strict kodata symlink enforcement (ko-build/ko#1619) 2. A YAML encoder error when a label selector filters all documents in a file (fixed in ko-build/ko fix-empty-docnodes-encoder-close) Pin to v0.18.1 as a temporary workaround until ko releases a fixed version. The kodata symlinks are also fixed in this branch. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
8 tasks
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/XXL
Member
|
/lgtm |
Member
|
/retest |
Member
|
/approve |
Collaborator
Author
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #10358
ko v0.19.0 introduced strict enforcement that kodata symlinks must not resolve outside the kodata root (ko-build/ko#1619). The existing LICENSE -> ../../../LICENSE symlinks in all cmd/*/kodata/ directories resolve to the repo root, which ko now rejects when tarring for any non-kind registry (including CI).
Replace the symlinks with actual copies of the LICENSE file.
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepFixes #10357
Release Notes