Skip to content

Add upload csv functionality - #218

Open
GregorioBlazquez wants to merge 49 commits into
mainfrom
issue/upload-csv
Open

Add upload csv functionality#218
GregorioBlazquez wants to merge 49 commits into
mainfrom
issue/upload-csv

Conversation

@GregorioBlazquez

Copy link
Copy Markdown
Collaborator

Related Issue #57

@sonarqube-colab-for-telefonicaid

Copy link
Copy Markdown

Failed Quality Gate failed

  • 0.00% Coverage on New Code (is less than 80.00%)
  • 0.00% Security Hotspots Reviewed on New Code (is less than 100.00%)

Project ID: telefonicaid_fiware-data-access_cd8fa257-acf6-4582-978f-0ad915357d62

View in SonarQube

@GregorioBlazquez
GregorioBlazquez marked this pull request as ready for review July 30, 2026 13:19
@GregorioBlazquez
GregorioBlazquez requested a review from fgalan July 30, 2026 13:19
Comment thread doc/03_api.md
}
```

#### Upload FDA `POST /{visibility}/fdas/upload`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should use a different API operation for this. Maybe we should use the current "Create FDA" operation, so the Content-Type (either application/json or multipart/form-data) which one to use.

This way we preserve the creation semantic under the same operation (as at the end the CSV upload also participates in that semantic, as an alternative way of creating FDAs).

Not sure. Either way has its on pros/cons. Let's talk about it.

Comment thread doc/03_api.md
| -------------------- | -------- | -------------------------------------------------------------------- | ------------------ |
| `Fiware-Service` | | Tenant or service, using the common mechanism of the FIWARE platform | `trantor` |
| `Fiware-ServicePath` | | NGSI hierarchical service path. Stored and exact-matched on access. | `/servicePath` |
| `Content-Type` | | Must be `multipart/form-data` | multipart boundary |

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this relates with text/csv or application/vnd.ms-excel, etc.

Let's discuss it.

@fgalan

fgalan commented Jul 31, 2026

Copy link
Copy Markdown
Member

Given a fda (let's name it fda01), can we distinguish if that FDA has been created uploading a CSV or it is a regular FDA PG-based or MongoDB-based using the GET /{visibility}/fdas/fda01 operation?

Comment thread package.json
"uuid": "~11.1.0",
"cron-parser": "~5.5.0"
"xlsx": "~0.18.5",
"csv-parse": "~7.0.0"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems dependencies are in alphabetical order. Maybe this line should be re-ordered?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants