-
Notifications
You must be signed in to change notification settings - Fork 0
Add upload csv functionality #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GregorioBlazquez
wants to merge
49
commits into
main
Choose a base branch
from
issue/upload-csv
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
96bd5c8
Add dependencies
GregorioBlazquez 4c41cdb
Add new env var FDA_MAX_UPLOAD_SIZE
GregorioBlazquez 12fe573
Add and refactor auxiliary functions
GregorioBlazquez b211bd0
Add upload method with multer for file uploads
GregorioBlazquez fe9429a
Update dependencies, add csv-parse
GregorioBlazquez 9fedb93
Add some debug in upload csv flow
GregorioBlazquez 5fbbda7
Improve csv parser
GregorioBlazquez 13bf008
Add timeColumn basic validation
GregorioBlazquez 3260d32
Improve and add error handling for toParquet
GregorioBlazquez e6f60f7
Fix toParquet error handling
GregorioBlazquez 670c8b7
Add new env var to .env.example
GregorioBlazquez f18bfaf
Upload FDA must be always cached
GregorioBlazquez 3209109
Move processUploadFDAJob to fetcher
GregorioBlazquez d824810
Fix drop temporal file
GregorioBlazquez 594060a
Fix drop temporal file
GregorioBlazquez 4f0c137
Fix .env.example
GregorioBlazquez 7fd04d8
Improve parseUploadedFile to work with complex multisheet xlsx files
GregorioBlazquez 68958e5
Improve logger debugs
GregorioBlazquez 555a743
Add updateFDAStatus in upload process
GregorioBlazquez 3af5f01
Add new env var FDA_UPLOAD_TMP_DIR
GregorioBlazquez a58b2d4
Persits in disk storage input file and use path, avoid memory problem…
GregorioBlazquez a91dd7b
Add temporal file deletion
GregorioBlazquez bef84a2
Add documentation in advanced topics
GregorioBlazquez dc0ba62
Merge branch 'main' into issue/upload-csv
GregorioBlazquez 93ab344
Fix merge main and errors
GregorioBlazquez 0dc9d28
Fix Unit tests
GregorioBlazquez ee02b78
Fix error
GregorioBlazquez 8eda4d9
Add some validation for upload FDAs
GregorioBlazquez f66a869
Improve error handling in db.js
GregorioBlazquez 49b4465
Add unit tests
GregorioBlazquez 4d8c342
Add validationId for post FDAs, DAs and datasources and upload FDAs
GregorioBlazquez 55c9aaa
Add validationId for post FDAs, DAs and datasources and upload FDAs
GregorioBlazquez 82d981d
Add upload unit tests
GregorioBlazquez 288b3e4
Fix unit tests and error
GregorioBlazquez 817edd7
Add upload integration tests
GregorioBlazquez 88cf05f
Update documentation
GregorioBlazquez c7128ca
Fix Lint
GregorioBlazquez c1de184
Fix Issues SonarCube in index.js
GregorioBlazquez 71b42ab
Fix Issues SonarCube
GregorioBlazquez 6c12846
Fix unit tests
GregorioBlazquez 9ea2768
Fix timeCoumn validation is asynchronous and add refreshPolicy valida…
GregorioBlazquez 3e9e164
Merge branch 'main' into issue/upload-csv
GregorioBlazquez 37180f0
Fix Issue SonarCube
GregorioBlazquez f830c33
Fix errors
GregorioBlazquez f93b30f
Fix asynchronous operations that weren't stopped
GregorioBlazquez 9bc0ffc
Fix error
GregorioBlazquez c79e6ef
Fix error
GregorioBlazquez 1ecf94e
Increase test coverage
GregorioBlazquez afc113e
Update CHANGES_NEXT_RELEASE
GregorioBlazquez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - Add: file upload endpoint POST /{visibility}/fdas/upload supporting CSV, XLS and XLSX files with configurable size limit (FDA_MAX_UPLOAD_SIZE) and automatic Parquet conversion (#301) |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems dependencies are in alphabetical order. Maybe this line should be re-ordered?