fix: schema for agent.image.pullSecrets#4014
fix: schema for agent.image.pullSecrets#4014thallgren merged 1 commit intotelepresenceio:release/v2from
Conversation
|
This looks good to me, but please ensure two things:
|
e0401d8 to
7586e08
Compare
|
I've now signed off on the commit, and manually added missing documentation to the chart's README.md. Oh, looks like |
d79dc89 to
da59dd3
Compare
Signed-off-by: Trevan Redmon <trevan.redmon@gmail.com>
da59dd3 to
af9e89e
Compare
|
The build is currently failing due to an external problem: https://gitlab.alpinelinux.org/alpine/aports/-/issues/17775. I expect it go get fixed very soon. I'll rerun the build and merge once that happens. |
Description
The
agent.image.pullSecretsis referenced by the deployment.yaml but is currently disallowed by the schema file. I need to use this configuration setting in my k8s environment. I currently use a workaround ofhelm upgrade --skip-schema-validationbut it would be nice not to need to skip validation.Checklist
./CHANGELOG.yml(our release notes are generated from this file).CONTRIBUTING.mdwith any special dev tricks I had to use to work on this code efficiently.CNCF Slack so that the "ok to test" label can be applied.