feat: add minReadySeconds option#776
Merged
robholland merged 4 commits intotemporalio:mainfrom Dec 29, 2025
Merged
Conversation
Contributor
|
I opened a different PR here #733 |
Contributor
Author
I would appreciate that! I did not see your PR before filing this one. I think this setup fits the standard of enabling separate values by service that @PhillypHenning is suggesting on the other change. |
Contributor
|
We should probably default to a server.minReadySeconds option for the server services like other fields do. Please can you add tests? |
Contributor
Author
@robholland , thanks for the feedback. Does the latest change fit your suggestion? |
robholland
approved these changes
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added minReadySeconds option for each deployment
Why?
#775
Checklist
Closes [Feature Request] allow minReadySeconds for deployments #775
How was this tested:
Setting minReadySeconds and then deploying. Pods will come up more gradually, giving them time for startup activities.
This is a standard feature in the latest Deployment spec. No need for special docs