feat: add minReadySeconds option

charts/temporal/templates/admintools-deployment.yaml

@@ -95,4 +95,7 @@ spec:
       tolerations:
         {{- toYaml . | nindent 8 }}
     {{- end }}
-{{- end }}
+    {{- with .Values.admintools.minReadySeconds }}
+      minReadySeconds: {{ . }}
+    {{- end }}
+{{- end }}

charts/temporal/templates/server-deployment.yaml

@@ -97,9 +97,9 @@ spec:
               protocol: TCP
           {{- if ne $service "worker" }}
           livenessProbe:
-             initialDelaySeconds: 150
-             tcpSocket:
-               port: rpc
+            initialDelaySeconds: 150
+            tcpSocket:
+              port: rpc
           {{- end }}
           volumeMounts:
             - name: config
@@ -156,6 +156,9 @@ spec:
       topologySpreadConstraints:
         {{- toYaml . | nindent 8 }}
     {{- end }}
+    {{- with (default $.Values.server.minReadySeconds $serviceValues.minReadySeconds) }}
+      minReadySeconds: {{ . }}
+    {{- end }}
 ---
 {{- end }}
 {{- end }}

charts/temporal/templates/web-deployment.yaml

@@ -87,4 +87,7 @@ spec:
       topologySpreadConstraints:
         {{- toYaml . | nindent 8 }}
     {{- end }}
+    {{- with .Values.web.minReadySeconds }}
+      minReadySeconds: {{ . }}
+    {{- end }}
   {{- end }}

charts/temporal/tests/server_deployment_test.yaml

@@ -97,6 +97,34 @@ tests:
           path: spec.template.metadata.annotations["prometheus.io/scrape"]
       - notExists:
           path: spec.template.metadata.annotations["prometheus.io/port"]
+  - it: minReadySeconds defaults to service wide resources
+    template: templates/server-deployment.yaml
+    documentSelector:
+      path: '$[?(@.metadata.name == "RELEASE-NAME-temporal-frontend")].kind'
+      value: Deployment
+      matchMany: true
+    set:
+      server:
+        minReadySeconds: 10
+    asserts:
+      - equal:
+          path: spec.template.spec.minReadySeconds
+          value: 10
+  - it: minReadySeconds favours service specific resources
+    template: templates/server-deployment.yaml
+    documentSelector:
+      path: '$[?(@.metadata.name == "RELEASE-NAME-temporal-frontend")].kind'
+      value: Deployment
+      matchMany: true
+    set:
+      server:
+        minReadySeconds: 10
+        frontend:
+          minReadySeconds: 30
+    asserts:
+      - equal:
+          path: spec.template.spec.minReadySeconds
+          value: 30
   - it: renders log config with defaults
     template: templates/server-configmap.yaml
     asserts:

charts/temporal/values.yaml

@@ -87,6 +87,7 @@ server:
   nodeSelector: {}
   tolerations: []
   affinity: {}
+  minReadySeconds: 0
   additionalVolumes: []
   additionalVolumeMounts: []
   additionalEnv: []
@@ -398,6 +399,7 @@ admintools:
   resources: {}
   containerSecurityContext: {}
   securityContext: {}
+  minReadySeconds: 0
   podDisruptionBudget: {}
 web:
   # additionalInitContainers: []
@@ -460,6 +462,7 @@ web:
   containerSecurityContext: {}
   securityContext: {}
   topologySpreadConstraints: []
+  minReadySeconds: 0
   podDisruptionBudget: {}
 schema:
   backoffLimit: 100