Skip to content

added support for servicelabels on services#840

Merged
robholland merged 1 commit intotemporalio:mainfrom
haakotsm:feat/add-support-serviceLabels
Jan 22, 2026
Merged

added support for servicelabels on services#840
robholland merged 1 commit intotemporalio:mainfrom
haakotsm:feat/add-support-serviceLabels

Conversation

@haakotsm
Copy link
Copy Markdown
Contributor

What was changed

  • server-service.yaml
    • Added service to the resourceLabel call
  • values.yaml
    • Added a serviceLabel field to each service
  • Tests
    • Added unit test to verify correct generation of service manifest

Why?

I am in need of custom set of labels on the service for our prometheus scrape metrics from the service monitor

  1. Closes
    No related issue, but I had a short conversation with Rob Holland on the community slack

  2. How was this tested:

Added a unit test to verify the correct generation of the service manifest

  1. Any docs updates needed?

Not that I am aware of

@haakotsm haakotsm requested a review from a team as a code owner January 22, 2026 14:08
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 22, 2026

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@robholland robholland merged commit 0cc25f2 into temporalio:main Jan 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants