Skip to content

added support for servicelabels on services #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robholland merged 1 commit into from
Jan 22, 2026
Merged

added support for servicelabels on services #840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/temporal/templates/server-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ kind: Service
metadata:
name: {{ include "temporal.componentname" (list $ $service) }}
labels:
{{- include "temporal.resourceLabels" (list $ $service "") | nindent 4 }}
{{- include "temporal.resourceLabels" (list $ $service "service") | nindent 4 }}
{{- if $serviceValues.service.annotations }}
annotations: {{- include "common.tplvalues.render" ( dict "value" $serviceValues.service.annotations "context" $) | nindent 4 }}
{{- end }}
Expand Down
19 changes: 19 additions & 0 deletions charts/temporal/tests/server_service_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,3 +530,22 @@ tests:
port: 9090
protocol: TCP
targetPort: metrics
- it: add custom label for frontend service
template: templates/server-service.yaml
documentSelector:
path: '$[?(@.metadata.name == "RELEASE-NAME-temporal-frontend")].kind'
value: Service
matchMany: true
set:
server:
frontend:
serviceLabels:
label1: value1
label2: value2
asserts:
- equal:
path: metadata.labels["label1"]
value: value1
- equal:
path: metadata.labels["label2"]
value: value2
5 changes: 5 additions & 0 deletions charts/temporal/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@ server:
deploymentStrategy: {}
podAnnotations: {}
podLabels: {}
serviceLabels: {}
resources: {}
nodeSelector: {}
tolerations: []
Expand Down Expand Up @@ -306,6 +307,7 @@ server:
deploymentStrategy: {}
podAnnotations: {}
podLabels: {}
serviceLabels: {}
resources: {}
nodeSelector: {}
tolerations: []
Expand Down Expand Up @@ -334,6 +336,7 @@ server:
deploymentStrategy: {}
podAnnotations: {}
podLabels: {}
serviceLabels: {}
resources: {}
nodeSelector: {}
tolerations: []
Expand Down Expand Up @@ -362,6 +365,7 @@ server:
deploymentStrategy: {}
podAnnotations: {}
podLabels: {}
serviceLabels: {}
resources: {}
nodeSelector: {}
tolerations: []
Expand Down Expand Up @@ -390,6 +394,7 @@ server:
deploymentStrategy: {}
podAnnotations: {}
podLabels: {}
serviceLabels: {}
resources: {}
nodeSelector: {}
tolerations: []
Expand Down