feat: Support sourcing database connection details from Kubernetes Secrets#853
Closed
ragutsky wants to merge 2 commits intotemporalio:mainfrom
Closed
feat: Support sourcing database connection details from Kubernetes Secrets#853ragutsky wants to merge 2 commits intotemporalio:mainfrom
ragutsky wants to merge 2 commits intotemporalio:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added support for sourcing database connection details (host, port, user, database) from Kubernetes Secrets via a new
existingSecretKeysconfiguration option. This complements the existingexistingSecretparameter which previously only supported passwords.Changes:
existingSecretKeysfield to allow mapping Secret keys to connection parametersexistingSecretKeysis configuredexistingSecretKeyscontinue to work as beforevalues.yamlWhy?
This addresses the feature request for comprehensive Secret-based configuration management beyond just passwords.
Checklist
Closes <>
How was this tested:
Added
existing_secret_keys_test.goto ensure new values are compatible with existing ones.Any docs updates needed?
Added docs to the following values files: