Skip to content

feat: Support sourcing database connection details from Kubernetes Secrets #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ragutsky wants to merge 2 commits into from
Closed

feat: Support sourcing database connection details from Kubernetes Secrets #853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0f5888
feat: Support sourcing database connection details from Kubernetes Se…
ragutsky Feb 22, 2026
3f43a0b
update docs
ragutsky Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 58 additions & 0 deletions charts/temporal/templates/_admintools-env.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,43 @@
{{- $driverConfig = $global.Values.elasticsearch -}}
{{- end -}}
{{- if eq $driver "cassandra" -}}
{{- $eskKeys := $driverConfig.existingSecretKeys | default dict -}}
- name: CASSANDRA_HOST
{{- if and $driverConfig.existingSecret (hasKey $eskKeys "hosts") }}
valueFrom:
secretKeyRef:
name: {{ $driverConfig.existingSecret }}
key: {{ index $eskKeys "hosts" }}
{{- else }}
value: {{ first (splitList "," (include "temporal.persistence.cassandra.hosts" (list $global $store))) }}
{{- end }}
- name: CASSANDRA_PORT
{{- if and $driverConfig.existingSecret (hasKey $eskKeys "port") }}
valueFrom:
secretKeyRef:
name: {{ $driverConfig.existingSecret }}
key: {{ index $eskKeys "port" }}
{{- else }}
value: {{ include "temporal.persistence.cassandra.port" (list $global $store) | quote }}
{{- end }}
- name: CASSANDRA_KEYSPACE
{{- if and $driverConfig.existingSecret (hasKey $eskKeys "keyspace") }}
valueFrom:
secretKeyRef:
name: {{ $driverConfig.existingSecret }}
key: {{ index $eskKeys "keyspace" }}
{{- else }}
value: {{ $driverConfig.keyspace }}
{{- end }}
- name: CASSANDRA_USER
{{- if and $driverConfig.existingSecret (hasKey $eskKeys "user") }}
valueFrom:
secretKeyRef:
name: {{ $driverConfig.existingSecret }}
key: {{ index $eskKeys "user" }}
{{- else }}
value: {{ $driverConfig.user }}
{{- end }}
- name: CASSANDRA_PASSWORD
valueFrom:
secretKeyRef:
Expand All @@ -34,16 +63,45 @@
{{- end }}
{{- end }}
{{- else if eq $driver "sql" -}}
{{- $eskKeys := $driverConfig.existingSecretKeys | default dict -}}
- name: SQL_PLUGIN
value: {{ include "temporal.persistence.sql.driver" (list $global $store) }}
- name: SQL_HOST
{{- if and $driverConfig.existingSecret (hasKey $eskKeys "host") }}
valueFrom:
secretKeyRef:
name: {{ $driverConfig.existingSecret }}
key: {{ index $eskKeys "host" }}
{{- else }}
value: {{ include "temporal.persistence.sql.host" (list $global $store) }}
{{- end }}
- name: SQL_PORT
{{- if and $driverConfig.existingSecret (hasKey $eskKeys "port") }}
valueFrom:
secretKeyRef:
name: {{ $driverConfig.existingSecret }}
key: {{ index $eskKeys "port" }}
{{- else }}
value: {{ include "temporal.persistence.sql.port" (list $global $store) | quote }}
{{- end }}
- name: SQL_DATABASE
{{- if and $driverConfig.existingSecret (hasKey $eskKeys "database") }}
valueFrom:
secretKeyRef:
name: {{ $driverConfig.existingSecret }}
key: {{ index $eskKeys "database" }}
{{- else }}
value: {{ include "temporal.persistence.sql.database" (list $global $store) }}
{{- end }}
- name: SQL_USER
{{- if and $driverConfig.existingSecret (hasKey $eskKeys "user") }}
valueFrom:
secretKeyRef:
name: {{ $driverConfig.existingSecret }}
key: {{ index $eskKeys "user" }}
{{- else }}
value: {{ $driverConfig.user }}
{{- end }}
- name: SQL_PASSWORD
valueFrom:
secretKeyRef:
Expand Down
107 changes: 104 additions & 3 deletions charts/temporal/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,11 @@ Source: https://stackoverflow.com/a/52024583/3027614
{{- $store := index . 1 -}}
{{- $storeConfig := index $global.Values.server.config.persistence $store -}}
{{- $driverConfig := $storeConfig.cassandra -}}
{{- with $driverConfig.secretKey -}}
{{- print . -}}
{{- $eskKeys := $driverConfig.existingSecretKeys | default dict -}}
{{- if hasKey $eskKeys "password" -}}
{{- index $eskKeys "password" -}}
{{- else if $driverConfig.secretKey -}}
{{- print $driverConfig.secretKey -}}
{{- else -}}
{{/* Cassandra password is optional, but we will create an empty secret for it */}}
{{- print "password" -}}
Expand Down Expand Up @@ -347,7 +350,10 @@ Source: https://stackoverflow.com/a/52024583/3027614
{{- $store := index . 1 -}}
{{- $storeConfig := index $global.Values.server.config.persistence $store -}}
{{- $driverConfig := $storeConfig.sql -}}
{{- if $driverConfig.secretKey -}}
{{- $eskKeys := $driverConfig.existingSecretKeys | default dict -}}
{{- if hasKey $eskKeys "password" -}}
{{- index $eskKeys "password" -}}
{{- else if $driverConfig.secretKey -}}
{{- print $driverConfig.secretKey -}}
{{- else if or $driverConfig.existingSecret $driverConfig.password -}}
{{- print "password" -}}
Expand Down Expand Up @@ -440,6 +446,101 @@ Usage:
{{- end }}
{{- end -}}

{{/*
Generate env vars for a persistence store's connection params.
For each field, emit secretKeyRef if existingSecretKeys has the key, else plain value.
Args: list of ($global, $store)
*/}}
{{- define "temporal.persistence.storeEnvVars" -}}
{{- $global := index . 0 -}}
{{- $store := index . 1 -}}
{{- $storeConfig := index $global.Values.server.config.persistence $store -}}
{{- $driver := include "temporal.persistence.driver" (list $global $store) -}}
{{- $prefix := "TEMPORAL_STORE" -}}
{{- if eq $store "visibility" -}}
{{- $prefix = "TEMPORAL_VISIBILITY_STORE" -}}
{{- end -}}
{{- if eq $driver "sql" -}}
{{- $driverConfig := $storeConfig.sql -}}
{{- $eskKeys := $driverConfig.existingSecretKeys | default dict -}}
- name: {{ $prefix }}_HOST
{{- if and $driverConfig.existingSecret (hasKey $eskKeys "host") }}
valueFrom:
secretKeyRef:
name: {{ $driverConfig.existingSecret }}
key: {{ index $eskKeys "host" }}
{{- else }}
value: {{ include "temporal.persistence.sql.host" (list $global $store) | quote }}
{{- end }}
- name: {{ $prefix }}_PORT
{{- if and $driverConfig.existingSecret (hasKey $eskKeys "port") }}
valueFrom:
secretKeyRef:
name: {{ $driverConfig.existingSecret }}
key: {{ index $eskKeys "port" }}
{{- else }}
value: {{ include "temporal.persistence.sql.port" (list $global $store) | quote }}
{{- end }}
- name: {{ $prefix }}_USER
{{- if and $driverConfig.existingSecret (hasKey $eskKeys "user") }}
valueFrom:
secretKeyRef:
name: {{ $driverConfig.existingSecret }}
key: {{ index $eskKeys "user" }}
{{- else }}
value: {{ include "temporal.persistence.sql.user" (list $global $store) | quote }}
{{- end }}
- name: {{ $prefix }}_DATABASE
{{- if and $driverConfig.existingSecret (hasKey $eskKeys "database") }}
valueFrom:
secretKeyRef:
name: {{ $driverConfig.existingSecret }}
key: {{ index $eskKeys "database" }}
{{- else }}
value: {{ include "temporal.persistence.sql.database" (list $global $store) | quote }}
{{- end }}
{{- else if eq $driver "cassandra" -}}
{{- $driverConfig := $storeConfig.cassandra -}}
{{- $eskKeys := $driverConfig.existingSecretKeys | default dict -}}
- name: {{ $prefix }}_HOSTS
{{- if and $driverConfig.existingSecret (hasKey $eskKeys "hosts") }}
valueFrom:
secretKeyRef:
name: {{ $driverConfig.existingSecret }}
key: {{ index $eskKeys "hosts" }}
{{- else }}
value: {{ include "temporal.persistence.cassandra.hosts" (list $global $store) | quote }}
{{- end }}
- name: {{ $prefix }}_PORT
{{- if and $driverConfig.existingSecret (hasKey $eskKeys "port") }}
valueFrom:
secretKeyRef:
name: {{ $driverConfig.existingSecret }}
key: {{ index $eskKeys "port" }}
{{- else }}
value: {{ include "temporal.persistence.cassandra.port" (list $global $store) | quote }}
{{- end }}
- name: {{ $prefix }}_USER
{{- if and $driverConfig.existingSecret (hasKey $eskKeys "user") }}
valueFrom:
secretKeyRef:
name: {{ $driverConfig.existingSecret }}
key: {{ index $eskKeys "user" }}
{{- else }}
value: {{ $driverConfig.user | quote }}
{{- end }}
- name: {{ $prefix }}_KEYSPACE
{{- if and $driverConfig.existingSecret (hasKey $eskKeys "keyspace") }}
valueFrom:
secretKeyRef:
name: {{ $driverConfig.existingSecret }}
key: {{ index $eskKeys "keyspace" }}
{{- else }}
value: {{ $driverConfig.keyspace | quote }}
{{- end }}
{{- end -}}
{{- end -}}

{{/*
To modify camelCase to hyphenated internal-frontend service name
*/}}
Expand Down
24 changes: 13 additions & 11 deletions charts/temporal/templates/server-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,22 +22,24 @@ data:
default:
{{- if eq (include "temporal.persistence.driver" (list $ "default")) "cassandra" }}
cassandra:
hosts: "{{ include "temporal.persistence.cassandra.hosts" (list $ "default") }}"
port: {{ include "temporal.persistence.cassandra.port" (list $ "default") }}
hosts: "{{ `{{ .Env.TEMPORAL_STORE_HOSTS }}` }}"
port: {{ `{{ .Env.TEMPORAL_STORE_PORT }}` }}
user: {{ `{{ .Env.TEMPORAL_STORE_USER }}` }}
keyspace: {{ `{{ .Env.TEMPORAL_STORE_KEYSPACE }}` }}
password: {{ `{{ .Env.TEMPORAL_STORE_PASSWORD | quote }}` }}
{{- with (omit $server.config.persistence.default.cassandra "hosts" "port" "password" "existingSecret") }}
{{- with (omit $server.config.persistence.default.cassandra "hosts" "port" "user" "keyspace" "password" "existingSecret" "existingSecretKeys") }}
{{- toYaml . | nindent 12 }}
{{- end }}
{{- else if eq (include "temporal.persistence.driver" (list $ "default")) "sql" }}
sql:
pluginName: "{{ include "temporal.persistence.sql.driver" (list $ "default") }}"
driverName: "{{ include "temporal.persistence.sql.driver" (list $ "default") }}"
databaseName: "{{ $server.config.persistence.default.sql.database }}"
connectAddr: "{{ include "temporal.persistence.sql.host" (list $ "default") }}:{{ include "temporal.persistence.sql.port" (list $ "default") }}"
databaseName: {{ `{{ .Env.TEMPORAL_STORE_DATABASE | quote }}` }}
connectAddr: "{{ `{{ .Env.TEMPORAL_STORE_HOST }}` }}:{{ `{{ .Env.TEMPORAL_STORE_PORT }}` }}"
connectProtocol: "tcp"
user: {{ include "temporal.persistence.sql.user" (list $ "default") }}
user: {{ `{{ .Env.TEMPORAL_STORE_USER }}` }}
password: {{ `{{ .Env.TEMPORAL_STORE_PASSWORD | quote }}` }}
{{- with (omit $server.config.persistence.default.sql "driver" "driverName" "host" "port" "connectAddr" "connectProtocol" "database" "databaseName" "user" "password" "existingSecret") }}
{{- with (omit $server.config.persistence.default.sql "driver" "driverName" "host" "port" "connectAddr" "connectProtocol" "database" "databaseName" "user" "password" "existingSecret" "existingSecretKeys") }}
{{- toYaml . | nindent 12 }}
{{- end }}
{{- end }}
Expand Down Expand Up @@ -69,12 +71,12 @@ data:
sql:
pluginName: "{{ include "temporal.persistence.sql.driver" (list $ "visibility") }}"
driverName: "{{ include "temporal.persistence.sql.driver" (list $ "visibility") }}"
databaseName: "{{ $server.config.persistence.visibility.sql.database }}"
connectAddr: "{{ include "temporal.persistence.sql.host" (list $ "visibility") }}:{{ include "temporal.persistence.sql.port" (list $ "visibility") }}"
databaseName: {{ `{{ .Env.TEMPORAL_VISIBILITY_STORE_DATABASE | quote }}` }}
connectAddr: "{{ `{{ .Env.TEMPORAL_VISIBILITY_STORE_HOST }}` }}:{{ `{{ .Env.TEMPORAL_VISIBILITY_STORE_PORT }}` }}"
connectProtocol: "tcp"
user: "{{ include "temporal.persistence.sql.user" (list $ "visibility") }}"
user: {{ `{{ .Env.TEMPORAL_VISIBILITY_STORE_USER }}` }}
password: {{ `{{ .Env.TEMPORAL_VISIBILITY_STORE_PASSWORD | quote }}` }}
{{- with (omit $server.config.persistence.visibility.sql "driver" "driverName" "host" "port" "connectAddr" "connectProtocol" "database" "databaseName" "user" "password" "existingSecret") }}
{{- with (omit $server.config.persistence.visibility.sql "driver" "driverName" "host" "port" "connectAddr" "connectProtocol" "database" "databaseName" "user" "password" "existingSecret" "existingSecretKeys") }}
{{- toYaml . | nindent 12 }}
{{- end }}
{{- end }}
Expand Down
2 changes: 2 additions & 0 deletions charts/temporal/templates/server-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,15 @@ spec:
secretKeyRef:
name: {{ include "temporal.persistence.secretName" (list $ "default") }}
key: {{ include "temporal.persistence.secretKey" (list $ "default") }}
{{- include "temporal.persistence.storeEnvVars" (list $ "default") | nindent 12 }}
{{- end }}
{{- if ne (include "temporal.persistence.driver" (list $ "visibility")) "custom" }}
- name: TEMPORAL_VISIBILITY_STORE_PASSWORD
valueFrom:
secretKeyRef:
name: {{ include "temporal.persistence.secretName" (list $ "visibility") }}
key: {{ include "temporal.persistence.secretKey" (list $ "visibility") }}
{{- include "temporal.persistence.storeEnvVars" (list $ "visibility") | nindent 12 }}
{{- end }}
{{- if and (hasKey $.Values.server "internalFrontend") $.Values.server.internalFrontend.enabled }}
- name: USE_INTERNAL_FRONTEND
Expand Down
2 changes: 1 addition & 1 deletion charts/temporal/templates/server-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ spec:
image: "{{ $.Values.admintools.image.repository }}:{{ $.Values.admintools.image.tag }}"
imagePullPolicy: {{ $.Values.admintools.image.pullPolicy }}
{{- if eq $driver "cassandra" }}
command: ['temporal-cassandra-tool', 'create', '-k', '{{ $storeConfig.cassandra.keyspace }}', '--replication-factor', '{{ $storeConfig.cassandra.replicationFactor }}'{{- if $storeConfig.cassandra.datacenter }}, '--datacenter', '{{ $storeConfig.cassandra.datacenter }}'{{- end }}]
command: ['temporal-cassandra-tool', 'create', '-k', '$(CASSANDRA_KEYSPACE)', '--replication-factor', '{{ $storeConfig.cassandra.replicationFactor }}'{{- if $storeConfig.cassandra.datacenter }}, '--datacenter', '{{ $storeConfig.cassandra.datacenter }}'{{- end }}]
{{- else if eq $driver "sql" }}
command: ['temporal-sql-tool', 'create-database']
{{- end }}
Expand Down
Loading