Enable conditional rendering for service definitions#856
Merged
robholland merged 3 commits intotemporalio:mainfrom Apr 1, 2026
Merged
Enable conditional rendering for service definitions#856robholland merged 3 commits intotemporalio:mainfrom
robholland merged 3 commits intotemporalio:mainfrom
Conversation
|
|
Contributor
Author
|
@robholland could you PTAL? We need this fix because our security policy requires removing all endpoints for disabled services, and currently the non-headless Service is still created even with |
Contributor
|
Looks good, please add a test to |
Contributor
Author
@robholland Done. Thanks! |
robholland
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added
{{- if or (not (hasKey $serviceValues "enabled")) $serviceValues.enabled }}conditional check inside the{{- range }}loop for the non-headless Service block intemplates/server-service.yaml.Why?
The non-headless Service block for
frontendandinternal-frontendhad noenabledcheck, so Service resources were created regardless of theenabledflag. The headless Service block already uses{{- if $serviceValues.enabled }}. This change makes the non-headless block consistent while using an opt-out pattern — services without an explicitenabledkey are rendered by default, and only those withenabled: falseare skipped.Checklist
enabled: falsefor individual services #855helm templatewithserver.internal-frontend.enabled: false→ internal-frontend Service not rendered.helm templatewithserver.internal-frontend.enabled: true→ Service rendered as expected.helm templatewithoutenabledkey set → Service rendered by default (opt-out behavior).