Skip to content

Enable conditional rendering for service definitions #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robholland merged 3 commits into from
Apr 1, 2026
Merged

Enable conditional rendering for service definitions #856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e4bff6
Enable conditional rendering for service definitions
lake-dunamu Mar 4, 2026
23e8673
Support compatibility
lake-dunamu Mar 4, 2026
33e9063
Add tests
lake-dunamu Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion charts/temporal/templates/server-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{{- if $.Values.server.enabled }}
{{- range $service := (list "frontend" "internal-frontend") }}
{{- $serviceValues := index $.Values.server $service }}
{{- if or (not (hasKey $serviceValues "enabled")) $serviceValues.enabled }}
apiVersion: v1
kind: Service
metadata:
Expand Down Expand Up @@ -39,6 +40,7 @@ spec:
---
{{- end }}
{{- end }}
{{- end }}

{{- if $.Values.server.enabled }}
{{- range $service := (list "frontend" "internal-frontend" "matching" "history" "worker") }}
Expand Down Expand Up @@ -99,4 +101,4 @@ spec:
---
{{- end }}
{{- end }}
{{- end }}
{{- end }}
34 changes: 34 additions & 0 deletions charts/temporal/tests/server_service_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,40 @@ tests:
containsDocument:
kind: Service
apiVersion: v1
- it: doesn't create frontend services when frontend is disabled
template: templates/server-service.yaml
set:
server:
frontend:
enabled: false
asserts:
- not: true
containsDocument:
kind: Service
apiVersion: v1
name: RELEASE-NAME-temporal-frontend
- not: true
containsDocument:
kind: Service
apiVersion: v1
name: RELEASE-NAME-temporal-frontend-headless
- it: doesn't create internal-frontend services when internal-frontend is disabled
template: templates/server-service.yaml
set:
server:
internal-frontend:
enabled: false
asserts:
- not: true
containsDocument:
kind: Service
apiVersion: v1
name: RELEASE-NAME-temporal-internal-frontend
- not: true
containsDocument:
kind: Service
apiVersion: v1
name: RELEASE-NAME-temporal-internal-frontend-headless
- it: app protocol default in frontend service
template: templates/server-service.yaml
documentSelector:
Expand Down
Loading