Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't mutate class attribute #115

Merged
merged 1 commit into from
May 23, 2024
Merged

Don't mutate class attribute #115

merged 1 commit into from
May 23, 2024

Conversation

dandavison
Copy link
Contributor

  • Don't mutate class attribute
  • Comment out unused imports

@dandavison
Don't mutate class attribute
87c805f 
- Comment out unused imports
@dandavison dandavison force-pushed the no-mutable-class-attribute branch from fa34460 to 87c805f Compare May 23, 2024 12:25
@cretz
Copy link
Member

cretz commented May 23, 2024

@dandavison - the CI issue is caused by macos-latest now pointing to macos-14 which is arm instead of intel. The fix is probably to use actions/setup-python@v4 instead of actions/setup-python@v1, set macos-intel and macos-arm as macos-12 and macos-14 respectively, and disable 3.8 for macos-arm. See temporalio/sdk-python#506. Can be done in this PR or in a separate one your choice (or work can just be put on the backlog if time is limited).

@dandavison dandavison merged commit bcb9836 into temporalio:main May 23, 2024
2 of 8 checks passed
@dandavison dandavison mentioned this pull request May 23, 2024
Closed
@dandavison
Copy link
Contributor Author

the CI issue is caused...

Thanks! Opened #117 for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dandavison @cretz