Skip to content

Don't mutate class attribute #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion encryption/codec.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import base64
import os
from typing import Iterable, List

Expand Down
4 changes: 2 additions & 2 deletions hello/hello_activity.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import asyncio
import logging
from dataclasses import dataclass
from datetime import timedelta

Expand Down Expand Up @@ -38,7 +37,8 @@ async def run(self, name: str) -> str:


async def main():
# Uncomment the line below to see logging
# Uncomment the lines below to see logging output
# import logging
# logging.basicConfig(level=logging.INFO)

# Start client
Expand Down
3 changes: 2 additions & 1 deletion hello/hello_mtls.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
from typing import Optional

from temporalio import activity, workflow
from temporalio.client import Client, TLSConfig
from temporalio.client import Client
from temporalio.service import TLSConfig
from temporalio.worker import Worker


Expand Down
4 changes: 2 additions & 2 deletions hello/hello_patch.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import asyncio
import logging
import sys
from dataclasses import dataclass
from datetime import timedelta
Expand Down Expand Up @@ -96,7 +95,8 @@ async def main():

version = sys.argv[1]

# Uncomment the line below to see logging
# Uncomment the lines below to see logging output
# import logging
# logging.basicConfig(level=logging.INFO)

# Start client
Expand Down
5 changes: 1 addition & 4 deletions hello/hello_search_attributes.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
import asyncio
from typing import List

from temporalio import workflow
from temporalio.client import Client, WorkflowExecutionDescription
from temporalio.common import SearchAttributeValues
from temporalio.converter import default as default_converter
from temporalio.client import Client
from temporalio.worker import Worker


Expand Down
3 changes: 2 additions & 1 deletion hello/hello_update.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@

@workflow.defn
class GreetingWorkflow:
is_complete = False
def __init__(self):
self.is_complete = False

@workflow.run
async def run(self) -> str:
Expand Down
Loading