Do not configure NPM workspace on the root project #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commenting here so GitHub sees me as "involved" in this and I can find it later and I get notifications etc. Apologies for the extra notification, James 🙏 |
GSmithApps
added a commit
to GSmithApps/samples-typescript
that referenced
this pull request
Feb 11, 2025
…activities - added samples for - infrequent polling - frequent polling - stateful activities - removed husky from the nextjs ecommerce app - added vscode launch.json to gitignore [DSE Jira Ticket](https://temporalio.atlassian.net/browse/DSE-21) Regarding the stateful activities: I added this because i learned how to do it while trying to implement the polling We can consider [this PR](temporalio#410) finished when we merge this one. Thomas fixed the other parts of it when he merged [this](https://github.com/temporalio/samples-typescript/pull/412/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L38) <!--- add/delete as needed ---> 1. How was this tested: I ran these three in my local and got expected behavior 2. Code cleanliness: ran linter and formatter ✅
GSmithApps
added a commit
to GSmithApps/samples-typescript
that referenced
this pull request
Feb 11, 2025
- added samples for - infrequent polling - frequent polling - removed husky from the nextjs ecommerce app - added vscode launch.json to gitignore [DSE Jira Ticket](https://temporalio.atlassian.net/browse/DSE-21) We can consider [this PR](temporalio#410) finished when we merge this one. Thomas fixed the other parts of it when he merged [this](https://github.com/temporalio/samples-typescript/pull/412/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L38) <!--- add/delete as needed ---> 1. How was this tested: I ran these two in my local and got expected behavior 2. Code cleanliness: ran linter and formatter ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Do not configure NPM workspace on the root repository. We specifically want
PNPM and NPM/YARN configuration to differ on this regard, so that the repository
can be used either as a monorepo (e.g.
pnpm installon the root directory) oras individual projects (e.g.
cd hello-world ; npm install, without installingdependencies on the whole repo).
That's how the PNPM setup was initially created. I added that at some point to
test something, and may have I forgot to remove before the final commit.