Skip to content

add infrequent polling sample, with benign application failure#422

Merged
THardy98 merged 2 commits intomainfrom
add_polling_sample_with_benign_exceptions
Jul 18, 2025
Merged

add infrequent polling sample, with benign application failure#422
THardy98 merged 2 commits intomainfrom
add_polling_sample_with_benign_exceptions

Conversation

@THardy98
Copy link
Copy Markdown
Contributor

What was changed

Added a polling sample, using BENIGN category for application failure

Why?

samples parity and usage of BENIGN application failure for activity failures.

Checklist

  • Blocked on Typescript SDK release (and npm package) that includes the category of ApplicationFailure
  1. How was this tested:
    Simple integration test

  2. Any docs updates needed?
    probably not

@THardy98 THardy98 requested a review from a team as a code owner June 20, 2025 14:01
@THardy98 THardy98 marked this pull request as draft June 20, 2025 14:02
@THardy98 THardy98 changed the title add frequent polling sample, with benign application failure [DRAFT/BLOCKED] add frequent polling sample, with benign application failure Jun 20, 2025
@THardy98
Copy link
Copy Markdown
Contributor Author

THardy98 commented Jun 20, 2025

sample is blocked on more recent release of TS SDK (and npm package) that includes the category field in ApplicationFailure

RFR

@THardy98 THardy98 force-pushed the add_polling_sample_with_benign_exceptions branch from 4b17364 to 1f54636 Compare June 21, 2025 13:55
@THardy98 THardy98 changed the title [DRAFT/BLOCKED] add frequent polling sample, with benign application failure [DRAFT/BLOCKED] add infrequent polling sample, with benign application failure Jun 21, 2025
@THardy98 THardy98 force-pushed the add_polling_sample_with_benign_exceptions branch from 1f54636 to bfbfba0 Compare July 15, 2025 14:44
@THardy98 THardy98 changed the title [DRAFT/BLOCKED] add infrequent polling sample, with benign application failure add infrequent polling sample, with benign application failure Jul 15, 2025
@THardy98 THardy98 marked this pull request as ready for review July 15, 2025 14:45
Comment thread polling/infrequent/README.md Outdated
@@ -0,0 +1,25 @@
# Frequently Polling Activity

This sample shows how we can implement frequent polling (1 second or faster) inside our Activity. The implementation is a loop that polls our service and then sleeps for the poll interval (1 second in the sample).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This readme is talking about frequent polling, but the sample is infrequent?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, should be infrequent, fixed

@THardy98 THardy98 requested a review from Sushisource July 17, 2025 18:59
@THardy98 THardy98 merged commit ffdd555 into main Jul 18, 2025
50 checks passed
@THardy98 THardy98 deleted the add_polling_sample_with_benign_exceptions branch July 18, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants