Rails README updates #269
Merged
Rails README updates #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
approved these changes
May 16, 2025
Comment on lines
+1156
to
+1161
| For ActiveRecord, or other general/ORM models that are used for a different purpose, it is not recommended to | ||
| try to reuse them as Temporal models. Eventually model purposes diverge and models for a Temporal workflows/activities | ||
| should be specific to their use for clarity and compatibility reasons. Also many Ruby ORMs do many lazy things and | ||
| therefore provide unclear serialization semantics. Instead, consider having models specific for workflows/activities and | ||
| translate to/from existing models as needed. See the [ActiveModel](#activemodel) section on how to do this with | ||
| ActiveModel objects. |
There was a problem hiding this comment.
Looks like a copy of what's above? Does it need to be in both spots?
There was a problem hiding this comment.
I intentionally put in both spots because I know some looking at data conversion may not look at rails and vice versa. Hopefully there's a future where docs.temporal.io obviates all of this.
cretz
force-pushed
the
rails-readme-updates
branch
from
8a6eb65 to
e906df7
Compare
cretz
force-pushed
the
rails-readme-updates
branch
from
e906df7 to
29036a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
ActiveModelsupport snippetChecklist