-
Notifications
You must be signed in to change notification settings - Fork 7
SFTP Updates #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
SFTP Updates #891
Conversation
68e662d
to
cd4d6e5
Compare
ff607a2
to
1cb6a07
Compare
@@ -345,11 +345,17 @@ jobs: | |||
git push | |||
fi | |||
|
|||
# Add to known hosts and create id_rsa file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you clarify why exactly this is needed and key itself is not enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayerofieiev-tt without it, it fails with the following error:
/opt/venv/lib/python3.10/site-packages/pysftp/__init__.py:61: UserWarning: Failed to load HostKeys from /github/home/.ssh/known_hosts. You will need to explicitly load HostKeys (cnopts.hostkeys.load(filename)) or disableHostKey checking (cnopts.hostkeys = None).
warnings.warn(wmsg, UserWarning)
Traceback (most recent call last):
File "/__w/pytorch2.0_ttnn/pytorch2.0_ttnn/tools/send_to_data_team.py", line 182, in <module>
sender.run()
File "/__w/pytorch2.0_ttnn/pytorch2.0_ttnn/tools/send_to_data_team.py", line 40, in run
self.send_file(file_path)
File "/__w/pytorch2.0_ttnn/pytorch2.0_ttnn/tools/send_to_data_team.py", line 51, in send_file
with pysftp.Connection(
File "/opt/venv/lib/python3.10/site-packages/pysftp/__init__.py", line 132, in __init__
self._tconnect['hostkey'] = self._cnopts.get_hostkey(host)
File "/opt/venv/lib/python3.10/site-packages/pysftp/__init__.py", line 71, in get_hostkey
raise SSHException("No hostkey for host %s found." % host)
paramiko.ssh_exception.SSHException: No hostkey for host *** found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayerofieiev-tt I created a ticket for this https://tenstorrent.atlassian.net/browse/DATA-671
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayerofieiev-tt it looks like you changed the title of this PR - but I doubt you did it :) Is this happening automatically?
cc @jmalone-tt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is happening automatically due to the recent change to PR when generating doc updates. Apologies for the inconvenience, I am working on a change to prevent this from happening
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joelsmithTT @ayerofieiev-tt this is ready for a final review.
A "short" test run with this code succeeded https://github.com/tenstorrent/pytorch2.0_ttnn/actions/runs/14453684858
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayerofieiev-tt a full test run is complete https://github.com/tenstorrent/pytorch2.0_ttnn/actions/runs/14454651714
e2d7b13
to
eba0bb9
Compare
eba0bb9
to
493281e
Compare
493281e
to
483a77d
Compare
faa2a1e
to
a333806
Compare
a343d1f
to
f5d33bc
Compare
This PR: 1. Creates `known_hosts` file and adds data team's host info to it 2. Creates `id_rsa` file
20e2ccb
to
43ba03d
Compare
This PR updates Documentation by rerunning autogenerated tests