Skip to content

SFTP Updates #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

SFTP Updates #891

wants to merge 9 commits into from

Conversation

acirikTT
Copy link
Contributor

@acirikTT acirikTT commented Apr 2, 2025

This PR updates Documentation by rerunning autogenerated tests

@acirikTT acirikTT force-pushed the ali/sftp-key-file branch from 68e662d to cd4d6e5 Compare April 3, 2025 13:45
@acirikTT acirikTT enabled auto-merge April 3, 2025 13:47
@acirikTT acirikTT force-pushed the ali/sftp-key-file branch 2 times, most recently from ff607a2 to 1cb6a07 Compare April 7, 2025 16:20
@@ -345,11 +345,17 @@ jobs:
git push
fi

# Add to known hosts and create id_rsa file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you clarify why exactly this is needed and key itself is not enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayerofieiev-tt without it, it fails with the following error:

/opt/venv/lib/python3.10/site-packages/pysftp/__init__.py:61: UserWarning: Failed to load HostKeys from /github/home/.ssh/known_hosts.  You will need to explicitly load HostKeys (cnopts.hostkeys.load(filename)) or disableHostKey checking (cnopts.hostkeys = None).
  warnings.warn(wmsg, UserWarning)
Traceback (most recent call last):
  File "/__w/pytorch2.0_ttnn/pytorch2.0_ttnn/tools/send_to_data_team.py", line 182, in <module>
    sender.run()
  File "/__w/pytorch2.0_ttnn/pytorch2.0_ttnn/tools/send_to_data_team.py", line 40, in run
    self.send_file(file_path)
  File "/__w/pytorch2.0_ttnn/pytorch2.0_ttnn/tools/send_to_data_team.py", line 51, in send_file
    with pysftp.Connection(
  File "/opt/venv/lib/python3.10/site-packages/pysftp/__init__.py", line 132, in __init__
    self._tconnect['hostkey'] = self._cnopts.get_hostkey(host)
  File "/opt/venv/lib/python3.10/site-packages/pysftp/__init__.py", line 71, in get_hostkey
    raise SSHException("No hostkey for host %s found." % host)
paramiko.ssh_exception.SSHException: No hostkey for host *** found.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayerofieiev-tt it looks like you changed the title of this PR - but I doubt you did it :) Is this happening automatically?

Screenshot 2025-04-10 at 10 40 54 AM

cc @jmalone-tt

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is happening automatically due to the recent change to PR when generating doc updates. Apologies for the inconvenience, I am working on a change to prevent this from happening

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joelsmithTT @ayerofieiev-tt this is ready for a final review.

A "short" test run with this code succeeded https://github.com/tenstorrent/pytorch2.0_ttnn/actions/runs/14453684858

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acirikTT acirikTT disabled auto-merge April 8, 2025 22:40
@acirikTT acirikTT enabled auto-merge April 8, 2025 22:40
@acirikTT acirikTT force-pushed the ali/sftp-key-file branch from e2d7b13 to eba0bb9 Compare April 9, 2025 15:48
@acirikTT acirikTT requested a review from ayerofieiev-tt April 9, 2025 15:49
@acirikTT acirikTT force-pushed the ali/sftp-key-file branch from eba0bb9 to 493281e Compare April 9, 2025 21:57
@ayerofieiev-tt ayerofieiev-tt changed the title SFTP updates Update PT2.0 Documentation Apr 10, 2025
@acirikTT acirikTT force-pushed the ali/sftp-key-file branch from faa2a1e to a333806 Compare April 10, 2025 14:29
@acirikTT acirikTT changed the title Update PT2.0 Documentation SFTP Updates Apr 10, 2025
@acirikTT acirikTT force-pushed the ali/sftp-key-file branch 2 times, most recently from a343d1f to f5d33bc Compare April 10, 2025 18:40
@acirikTT acirikTT force-pushed the ali/sftp-key-file branch from 20e2ccb to 43ba03d Compare April 15, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants